Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 18 register support for SMC and SVC calls for AArch64 platforms #10685

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add 18 register support for SMC and SVC calls for AArch64 platforms #10685

wants to merge 4 commits into from
+105 −20

Conversation

kuqin12
Copy link
Contributor

@kuqin12 kuqin12 commented Jan 27, 2025

Description

Current SMC and SVC only supports up to 8 registers.

However, the FF-A spec has definition for FFA direct request 2 which could use up to 18 registers.

This change is added to support such use case.

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

This was tested on QEMU SBSA and booted to Windows

Integration Instructions

N/A

@kuqin12
ArmPkg: ArmSmcLib: Support all 18 registers
12eb0c8 
This change updated the ARM SMC call to support all x0-x17 registers.

Signed-off-by: Kun Qin <[email protected]>
@kuqin12
ArmPkg: ArmSvcLib: Support all 18 registers
83339c2 
This change updated the ARM SVC call to support all x0-x17 registers.

Signed-off-by: Kun Qin <[email protected]>
@kuqin12
ArmPkg: ArmFfaLib: Update FF-A direct message to support 18 registers
ddac083 
This change expands the support of FF-A direct message 2 call to use the
full 18 registers.

Signed-off-by: Kun Qin <[email protected]>
@kuqin12
ArmPkg: ArmStandaloneMmCoreEntryPoint: Support 18 register DIRECT_REQ2
ef9b5ac 
This change added the support for using 18 registers when FF-A
DIRECT_REQ2 is used to communicate with MM core.

This change was tested on QEMU SBSA and booted to Windows.

Signed-off-by: Kun Qin <[email protected]>
@kuqin12 kuqin12 marked this pull request as ready for review January 27, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardbiesheuvel ardbiesheuvel Awaiting requested review from ardbiesheuvel

@leiflindholm leiflindholm Awaiting requested review from leiflindholm

@samimujawar samimujawar Awaiting requested review from samimujawar

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kuqin12