EmbeddedPkg/Universal/MmcDxe: Reorder multi-block abort sequence

[mariam-elshakfy-linaro]

Description

This change moves multi-block stop transmission scenario (CMD12) before getting card status (CMD13).

This follows the abort sequence mentioned in:
SD Host Controller Simplified Specification Version 4.20, Section 3.8.1 Abort Command Sequence

Additionally, make use of MmcStopTransmission to remove duplicate code.

• Breaking change?
  • Breaking change - Does this PR cause a break in build or boot behavior?
  • Examples: Does it add a new library class or move a module to a different repo.
• Impacts security?
  • Security - Does this PR have a direct security impact?
  • Examples: Crypto algorithm change or buffer overflow fix.
• Includes tests?
  • Tests - Does this PR include any explicit test code?
  • Examples: Unit tests or integration tests.

How This Was Tested

Tested on KV260 (new EDK-II port)

Integration Instructions

N/A

[leiflindholm]

Word of warning: this driver is not well supported. None of the EmbeddedPkg maintainers are actively using it or very familiar with the interface.

Ultimately, this should be replaced by Bus/Pci/SdMmcPciHcDxe/ used with NonDiscoverablePciDeviceDxe.

Until then, unless someone else volunteers to take on maintainership of this driver, I'm intending to flag it as "unmaintained".

[mariam-elshakfy-linaro]

Word of warning: this driver is not well supported. None of the EmbeddedPkg maintainers are actively using it or very familiar with the interface.

Ultimately, this should be replaced by Bus/Pci/SdMmcPciHcDxe/ used with NonDiscoverablePciDeviceDxe.

Until then, unless someone else volunteers to take on maintainership of this driver, I'm intending to flag it as "unmaintained".

I was wandering about that actually. Does EDK-2 have any list with what drivers are maintained (or the deprecated ones)?

[leiflindholm]

Until then, unless someone else volunteers to take on maintainership of this driver, I'm intending to flag it as "unmaintained".

I was wandering about that actually. Does EDK-2 have any list with what drivers are maintained (or the deprecated ones)?

We have the syntax for it in https://github.com/tianocore/edk2/blob/master/Maintainers.txt#L31, but generally the feeling is that something that is unmaintained for more than a very short period should be dropped/archived.

[michalsimek]

Until then, unless someone else volunteers to take on maintainership of this driver, I'm intending to flag it as "unmaintained".

I was wandering about that actually. Does EDK-2 have any list with what drivers are maintained (or the deprecated ones)?

We have the syntax for it in https://github.com/tianocore/edk2/blob/master/Maintainers.txt#L31, but generally the feeling is that something that is unmaintained for more than a very short period should be dropped/archived.

The package is used in edk2-platforms by 3 more boards:

Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc:345: EmbeddedPkg/Universal/MmcDxe/MmcDxe.inf
Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf:143: INF EmbeddedPkg/Universal/MmcDxe/MmcDxe.inf
Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc:414: EmbeddedPkg/Universal/MmcDxe/MmcDxe.inf
Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.fdf:122: INF EmbeddedPkg/Universal/MmcDxe/MmcDxe.inf
Platform/Hisilicon/HiKey/HiKey.dsc:224: EmbeddedPkg/Universal/MmcDxe/MmcDxe.inf
Platform/Hisilicon/HiKey/HiKey.fdf:130: INF EmbeddedPkg/Universal/MmcDxe/MmcDxe.inf

Are you saying that all of them should be converted to Bus/Pci/SdMmcPciHcDxe/?

[leiflindholm]

The package is used in edk2-platforms by 3 more boards:

Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc:345: EmbeddedPkg/Universal/MmcDxe/MmcDxe.inf Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf:143: INF EmbeddedPkg/Universal/MmcDxe/MmcDxe.inf Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc:414: EmbeddedPkg/Universal/MmcDxe/MmcDxe.inf Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.fdf:122: INF EmbeddedPkg/Universal/MmcDxe/MmcDxe.inf Platform/Hisilicon/HiKey/HiKey.dsc:224: EmbeddedPkg/Universal/MmcDxe/MmcDxe.inf Platform/Hisilicon/HiKey/HiKey.fdf:130: INF EmbeddedPkg/Universal/MmcDxe/MmcDxe.inf

Are you saying that all of them should be converted to Bus/Pci/SdMmcPciHcDxe/?

At least the latter two are candidates for deletion/archiving. @samimujawar is ArmVExpress-FVP considered actively maintained by Arm?