OvmfPkg: Introduce UEFI config support for fw_cfg v2 #10668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigix25
force-pushed
the
disable_uiapp_v2
branch
5 times, most recently
from
1ffe864 to
4f21032
Compare
tianocore-assign-reviewers
bot
requested review from
ardbiesheuvel,
elmarco,
jongwu,
jyao1,
kraxel,
mdroth,
mxu9,
ruleof2,
tlendacky,
tperard and
weltling
|
It is not clear at all from the patches why any of this is needed. And commits with no text at all are really not done. So please add some text to every commit why it is needed. And don't worry about duplication, each commit should make sense by itself, so if there is some underlying goal that gets documented numerous times, that is perfectly fine. |
Add BootManagerMenuApp to all OvmfPkg dependencies. To make UiApp optional, switch from UiApp to BootManagerMenuApp as default BootManagerMenu. Signed-off-by: Gerd Hoffmann <[email protected]> Signed-off-by: Luigi Leonardi <[email protected]>
This is part of the effort to enable/disable firmware configuration (UiApp) from the QEMU CLI. Because the UiApp can be disabled at runtime and it's currently the default BootManagerMenu, change the default from UiApp to BootManagerMenuApp. Signed-off-by: Gerd Hoffmann <[email protected]> Signed-off-by: Luigi Leonardi <[email protected]>
Setting the LOAD_OPTION_CATEGORY_APP flag for EFI Shell prevents the boot loader from using it as a fallback if all other entries fail to boot. With a boot manager menu available, it can be annoying to enter the EFI Shell directly, because from the menu, the user can try to boot again (e.g. temporary network problem) or enter the shell/firmware config only if necessary. Signed-off-by: Gerd Hoffmann <[email protected]> Signed-off-by: Luigi Leonardi <[email protected]>
…tion Introduce gUiAppFileGuid: it has the same value of UiApp guid defined in the .inf file. This is used to register UiApp as a boot entry in the BootManagerMenu. This registration is done in PlatformBootManagerBeforeConsole because it must be done before the hotkeys are registered. This is because in a system with hotkeys still bound to UiApp, but with firmware disabled, you can still boot into the latter by hitting ESC or F2 during boot. UiApp can be enabled/disabled using fw_cfg option FirmwareSetupSupport Signed-off-by: Gerd Hoffmann <[email protected]> Signed-off-by: Luigi Leonardi <[email protected]>
gUiAppFileGuid, which is used to register EFI Firmware Config as a boot option, has the same value as UiApp guid. This would trigger a duplicate guid error from the CI pipeline, but because these two guids are necessary, this commit adds a duplicate exception. Signed-off-by: Luigi Leonardi <[email protected]>
OvmfFindLoadOption behaves like EfiBootManagerFindLoadOption, it searches for an entry in the array: an entry is found if the two paths are equal. This removes possible duplicates in the boot entries: two entries with the same path and different attributes are not detected as equal by EfiBootManagerFindLoadOption. In this case, the old entry is deleted and replaced by the new one. Signed-off-by: Luigi Leonardi <[email protected]>
…etup Document FirwareSetup fw_cfg option for QEMU CLI: it allows to enable/disable UiApp at runtime. Signed-off-by: Luigi Leonardi <[email protected]>
luigix25
force-pushed
the
disable_uiapp_v2
branch
from
4f21032 to
be3a06b
Compare
|
@ardbiesheuvel Commits messages are now more verbose, please let me know if you want me to change anything! I rebased on lastest master, code is unchanged. |
kraxel
approved these changes
Feb 7, 2025
tlendacky
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is linked to #6494. This is to disable the UEFI config using fw_cfg from QEMU cli.
The approach is to change the default BootManagerMenu from UiApp to BootManagerMenuApp.
UiApp, if enabled, is added as a boot entry.
How This Was Tested
Run QEMU on X86-64 with and without the fw_cfg flag set.
For reference qemu -fw_cfg name=opt/org.tianocore/FirmwareSetupSupport=no
Integration Instructions
N/A