OvmfPkg/X64: add opt/org.tianocore/UninstallMemAttrProtocol support #10667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for opt/org.tianocore/UninstallMemAttrProtocol, to allow turning off EFI_MEMORY_ATTRIBUTE_PROTOCOL, simliar to ArmVirtPkg. Signed-off-by: Gerd Hoffmann <[email protected]>
tianocore-assign-reviewers
bot
requested review from
ardbiesheuvel,
elmarco,
jyao1 and
tperard
|
Is there a bug report about this for GRUB? |
https://issues.redhat.com/browse/RHEL-74341 Note it's not limited to redhat, I've seen suse and debian builds fail too on a quick test. Probably because the distros copy broken patches from each other due to grub upstreaming being slow. |
|
I'll consider this once this is fully diagnosed and fixed on the distro side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for opt/org.tianocore/UninstallMemAttrProtocol, to allow
turning off EFI_MEMORY_ATTRIBUTE_PROTOCOL, simliar to ArmVirtPkg.
Signed-off-by: Gerd Hoffmann [email protected]
rant
I hate to do this, but things are breaking left and right. This time
it is not shim, 15.8 works fine and almost everyone has rolled out
updates meanwhile. But now grub gets the NX stuff wrong, and following
that the linux kernel efi stub pagefaults.
Apparently it happens due something in the huge pile of distro
downstream patches doing some stupid legacy x86 linux things.
Vanilla 2.12 grub is doing fine.
aarch64 is doing fine too.
Even
chainloader $vmlinuzworks.Only
linux $vmlinuxon x64 distro builds explodes ...