Edkrepo: Logger functionality without ui_functions #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ashedesimone
left a comment
ashedesimone
left a comment
There was a problem hiding this comment.
For all new classes you should have an init even if it only calls the parent classes init. It will work better than a comment to describe that use.
Add a short doc string to each class indicating its purpose and describing any non-obvious deteails
Consistently format your class names
Consider renaming functions to they provide more clarity as to what they do. ex. format to format_log_file
hrsh25
force-pushed
the
logger
branch
3 times, most recently
from
64b377b to
58e851e
Compare
Signed-off-by: Harsh Vora [email protected]
ashedesimone
approved these changes
Dec 21, 2022
kevinsun49
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harsh Vora [email protected]