Make Operation::name() a method rather than an associated function
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobypilling
approved these changes
Nov 14, 2024
moz-v2v-gh
pushed a commit
to mozilla/releases-comm-central
that referenced
this pull request
Nov 14, 2024
On top of thunderbird/ews-rs#28, which the bug is about, this commit also vendors in thunderbird/ews-rs#29, which brings a fix for protocol logging. Differential Revision: https://phabricator.services.mozilla.com/D229016 --HG-- extra : amend_source : 8c7e8334f800291bbcf9012263ef1dfd740a307e
github-actions bot
pushed a commit
to thunderbird/comm-unified-l10n
that referenced
this pull request
Nov 15, 2024
On top of thunderbird/ews-rs#28, which the bug is about, this commit also vendors in thunderbird/ews-rs#29, which brings a fix for protocol logging. Differential Revision: https://phabricator.services.mozilla.com/D229016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like an oversight from #22. Retrieving the name from an operation should be done as
op.name(); using an associated function would mean we'd need to call e.g.GetItem::name(), which would make the method a bit redundant.