Skip to content

Format Device Grant verification code input - #154

Merged
thiva-k merged 1 commit into
thunder-id:mainfrom
Yathusiga27:device-grant-code-input
Nov 4, 2026
Merged

thiva-k merged 1 commit into
thunder-id:mainfrom
Yathusiga27:device-grant-code-input

Conversation

@Yathusiga27

@Yathusiga27 Yathusiga27 commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Purpose

Make Device Grant verification codes easier to read and enter by displaying them in the familiar ABCD-EFGH format in the SDKs.

Approach

Special-case the Device Grant user_code field in each SDK’s existing OTP flow renderer. Show a visual separator after the fourth character and remove hyphens and whitespace from pasted or prefilled codes before submission. Other OTP fields retain their existing behavior.

Related Issues

Related PRs

Checklist

  • Followed the contribution guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Tests provided. (Add links if there are any)
    • Unit Tests
    • Integration Tests
  • Breaking changes. (Fill if applicable)
    • Breaking changes section filled.
    • breaking change label added.
  • Cross-SDK parity. Exactly one of parity/prs-raised or parity/prs-not-needed added.
    • If parity/prs-raised, the port links are posted as a reply on the parity check's comment.

Security checks

  • Followed secure coding standards.
  • Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.

Signed-off-by: Yathusiga27 <yathu2708@gmail.com>
@coderabbitai

coderabbitai Bot commented Nov 4, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

🔀 Cross-SDK feature parity

Does this change need to ship in the other ThunderID SDKs too? This check stays red until one of these labels answers that:

Label What it asserts
parity/prs-raised The ports exist in every other SDK this change reaches, or are recorded as not applying there.
parity/prs-not-needed Nothing to port: a fix, refactor, docs, CI, dependency bump, release, or a change specific to this platform.

Ports (DO NOT EDIT)

  • thunder-id/ios-sdks, iOS
  • thunder-id/android-sdks, Android
  • thunder-id/flutter-sdks, Flutter

No sibling SDKs accounted for on this thread yet.

Important

Reply to this comment with this block, filled in. The boxes above tick
themselves when you post it.

- thunder-id/ios-sdks: <paste the port link here>
- thunder-id/android-sdks: <paste the port link here>
- thunder-id/flutter-sdks: <paste the port link here>

A link can be a pull request or a tracked issue, written in full or as thunder-id/ios-sdks#123.
Where the change does not reach an SDK, replace the placeholder with N/A and a short
reason, as in - thunder-id/ios-sdks: N/A, the capability has no equivalent there.

The contract is in the SDK development specification.

@thiva-k thiva-k added the parity/prs-pending Porting in the other SDKs are still pending and issues are created label Nov 4, 2026
@thiva-k
thiva-k merged commit 29ca317 into thunder-id:main Nov 4, 2026
5 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parity/prs-pending Porting in the other SDKs are still pending and issues are created

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants