Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update formats in engine.py #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

atychyna
Copy link

@atychyna atychyna commented Mar 3, 2024

libvips uses target with dots so change few existing formats to conform to that.

flake was failing for me but after commenting it out the result of running make test:

------------------------------------------------------------------------------
Ran 18 tests in 0.50s

---------- coverage: platform linux, python 3.10.1-final-0 -----------
Name                                               Stmts   Miss  Cover
----------------------------------------------------------------------
thumbor_vips_engine/__init__.py                        1      0   100%
thumbor_vips_engine/engine.py                         78     16    79%
thumbor_vips_engine/testing/__init__.py                1      0   100%
thumbor_vips_engine/testing/engine_test_suite.py     111      6    95%
----------------------------------------------------------------------
TOTAL                                                191     22    88%


--------------------------- snapshot report summary ----------------------------

14 snapshots passed.

OK
************* Module /home/ec2-user/thumbor-vips-engine/pylintrc
pylintrc:1:0: R0022: Useless option value for '--disable', 'bad-continuation' was removed from pylint, see https://github.com/pylint-dev/pylint/pull/3571. (useless-option-value)
pylintrc:1:0: R0022: Useless option value for '--disable', 'no-self-use' was moved to an optional extension, see https://pylint.readthedocs.io/en/latest/whatsnew/2/2.14/summary.html#removed-checkers. (useless-option-value)

------------------------------------
Your code has been rated at 10.00/10

libvips uses target with dots so change few existing formats to conform to that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant