Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DiscreteSACExperimentBuilder not exposing with_actor_factory_default #1250

Merged
merged 5 commits into from
Mar 2, 2025

Conversation

opcode81
Copy link
Collaborator

@opcode81 opcode81 commented Mar 1, 2025

  • I have added the correct label(s) to this Pull Request or linked the relevant issue(s)
  • I have provided a description of the changes in this Pull Request
  • I have added documentation for my changes and have listed relevant changes in CHANGELOG.md
  • If applicable, I have added tests to cover my changes.
  • I have reformatted the code using poe format
  • I have checked style and types with poe lint and poe type-check
  • (Optional) I ran tests locally with poe test
    (or a subset of them with poe test-reduced) ,and they pass
  • (Optional) I have tested that documentation builds correctly with poe doc-build

Fixes #1248

Additional Changes:

  • Add information on Windows-specific developer configuration
  • Fix an incorrect docstring

@opcode81 opcode81 added bug Something isn't working documentation labels Mar 1, 2025
@opcode81 opcode81 force-pushed the fix/discrete-sac-default-actor-factory branch from 659cf62 to cf42f15 Compare March 1, 2025 14:07
@opcode81 opcode81 force-pushed the fix/discrete-sac-default-actor-factory branch from cf42f15 to 8b2aae3 Compare March 1, 2025 14:23
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.29%. Comparing base (c4ae7cd) to head (8b2aae3).

Files with missing lines Patch % Lines
tianshou/highlevel/experiment.py 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1250   +/-   ##
=======================================
  Coverage   85.28%   85.29%           
=======================================
  Files         102      102           
  Lines        9078     9083    +5     
=======================================
+ Hits         7742     7747    +5     
  Misses       1336     1336           
Flag Coverage Δ
unittests 85.29% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@opcode81 opcode81 marked this pull request as ready for review March 1, 2025 16:28
@Trinkle23897 Trinkle23897 merged commit 90846f6 into master Mar 2, 2025
4 checks passed
@Trinkle23897 Trinkle23897 deleted the fix/discrete-sac-default-actor-factory branch March 2, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method _with_actor_factory_default and with_actor_factory_default
3 participants