Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy to netlify #72

Closed
wants to merge 6 commits into from
Closed

Deploy to netlify #72

wants to merge 6 commits into from

Conversation

infiniteltd
Copy link

Updated the README.md file to fix issue #62 "documentation on how to deploy to netlify".

@vercel
Copy link

vercel bot commented Oct 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
terminal-portfolio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 7:03pm

@thtauhid
Copy link
Owner

thtauhid commented Oct 3, 2023

  1. Please remove or rephrase the line Considering the fact that they are a large web hosting server as compared to vercel.
    We don't want to mention which provider is larger.
  2. Consider removing the bash prefix
    image

Everything else looks good.

@infiniteltd
Copy link
Author

Changes made. Please view and update.

thtauhid
thtauhid requested changes Oct 4, 2023
View reviewed changes
Copy link
Owner

@thtauhid thtauhid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you uncomment this part?

  #[[redirects]]
  #  from = "/*"
  #  to = "/index.html"
  #  status = 200

@infiniteltd
Copy link
Author

I can't seem to find this section in the project. Please can you point me to the right place where you saw it ?

@thtauhid
Copy link
Owner

thtauhid commented Oct 4, 2023

Please check the attached image
image

@infiniteltd
Copy link
Author

Hello can you check again?

@thtauhid
Copy link
Owner

thtauhid commented Oct 6, 2023

Hi @infiniteltd
Remove the netlify.toml file altogether.

@thtauhid thtauhid closed this Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thtauhid thtauhid thtauhid requested changes

Assignees
No one assigned
Labels
change requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@infiniteltd @thtauhid