Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: introduce react-icons #56

Closed
wants to merge 1 commit into from
Closed

build: introduce react-icons #56

wants to merge 1 commit into from

Conversation

sdanialraza
Copy link

This introduces react icons package and resolves #9.

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
terminal-portfolio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 8:37am

@Kritika30032002
Copy link
Contributor

adding react-icons library to the package.json does not create any effect as it is not used anywhere in the project.

@sdanialraza
Copy link
Author

I wasn't sure if the icons can already be used somewhere, can they be?

@Kritika30032002
Copy link
Contributor

If it was used, then the library had been included. When we use any library then only we include it otherwise it affects performance of website.

@sdanialraza
Copy link
Author

There was an issue open for this, so I would assume the icons would be used very soon.

@Kritika30032002
Copy link
Contributor

Okay

@thtauhid
Copy link
Owner

thtauhid commented Oct 2, 2023

Currently, we are not using any icon library.
We need to introduce an icon library.

Expected outcome:
Users should be able to easily add icons to their data.json file.
We'll also need to add support for displaying the icon.
Currently, the app looks like this-
image
In the future when icon support is implemented we should be able to replace the text Email with an envelope icon.

Sorry for any confusion.

@thtauhid thtauhid closed this Oct 2, 2023
@sdanialraza sdanialraza deleted the build/introduce-react-icons branch October 2, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon support
3 participants