feat: hono party #157
Merged
feat: hono party #157
+450
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f51bf60 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
aulneau
force-pushed
the
feat/hono-party
branch
from
7446b07 to
08b68bb
Compare
aulneau
force-pushed
the
feat/hono-party
branch
from
08b68bb to
0411b0e
Compare
|
@yusukebe should this be in this repo or the hono repo? whatever you prefer, happy to do that. |
threepointone
approved these changes
Feb 3, 2025
packages/hono-party/package.json
Outdated
Comment on lines
31
to
32
| "hono": "^4", | ||
| "partyserver": "workspace:*" |
There was a problem hiding this comment.
maybe these should be peer deps too
yusukebe
reviewed
Feb 4, 2025
packages/hono-party/package.json
Outdated
| "license": "ISC", | ||
| "description": "", | ||
| "dependencies": { | ||
| "hono": "^4", |
|
We can include this in our |
|
This is great! What I was wondering was whether to include |
|
taking over this pr, will try to land it today |
yusukebe
approved these changes
Feb 4, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this implements a middleware for hono so you can expose many partyservers from a single hono app :)