Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream/buffer: remove ticker publishing for websocket orderbook updates #1681

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shazbert
Copy link
Collaborator

@shazbert shazbert commented Oct 14, 2024

PR Description

  • Removes intentional restriction of websocket orderbook publication of change through data handler as engine websocket routine handling couldn't keep up with updates. This limits Was limiting change detection through channel communication when using websocket incremental orderbook updates.

Fixes # (issue)

Type of change

Please delete options that are not relevant and add an x in [] as item is complete.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.

  • go test ./... -race
  • golangci-lint run
  • Test X

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally and on Github Actions with my changes
  • Any dependent changes have been merged and published in downstream modules

@shazbert shazbert added the review me This pull request is ready for review label Oct 14, 2024
@shazbert shazbert requested a review from a team October 14, 2024 23:27
@shazbert shazbert self-assigned this Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.08%. Comparing base (4de4e3d) to head (6267626).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1681      +/-   ##
==========================================
- Coverage   37.09%   37.08%   -0.01%     
==========================================
  Files         414      414              
  Lines      180264   180242      -22     
==========================================
- Hits        66860    66845      -15     
+ Misses     105549   105541       -8     
- Partials     7855     7856       +1     
Files with missing lines Coverage Δ
config/config.go 86.96% <ø> (-0.08%) ⬇️
exchanges/stream/buffer/buffer.go 71.48% <100.00%> (+2.34%) ⬆️

... and 13 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me This pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant