Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bithumb: Add subscription configuration #1618

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gbjk
Copy link
Collaborator

@gbjk gbjk commented Aug 17, 2024

Bithumb

  • Add subscription configuration

New Library Dependencies

  • sprig ( Also included in 4 other template PRs )

Type of change

  • New feature (non-breaking change which adds functionality)

@gbjk gbjk added the review me This pull request is ready for review label Aug 17, 2024
@gbjk gbjk self-assigned this Aug 17, 2024
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 36.36%. Comparing base (225429b) to head (56a820f).
Report is 45 commits behind head on master.

Files with missing lines Patch % Lines
exchanges/bithumb/bithumb_websocket.go 86.95% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1618   +/-   ##
=======================================
  Coverage   36.36%   36.36%           
=======================================
  Files         422      422           
  Lines      183105   183099    -6     
=======================================
+ Hits        66588    66589    +1     
+ Misses     108475   108472    -3     
+ Partials     8042     8038    -4     
Files with missing lines Coverage Δ
exchanges/bithumb/bithumb_wrapper.go 29.78% <100.00%> (+0.10%) ⬆️
exchanges/subscription/subscription.go 100.00% <ø> (ø)
exchanges/bithumb/bithumb_websocket.go 50.33% <86.95%> (+6.02%) ⬆️

... and 18 files with indirect coverage changes

Copy link
Collaborator

@shazbert shazbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. I can see why the add for extra dependency; I am on the fence to add this just for mustToJson but it makes templating a lot easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium priority rebase/merge of master required review me This pull request is ready for review szrc shazbert review complete
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

3 participants