Add re.findall to pick out re matches #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft because it needs documentation. |
thp
reviewed
Mar 12, 2024
thp
requested changes
Mar 12, 2024
There was a problem hiding this comment.
In general, I don't mind a re.findall(), but people might be tempted to use it to "parse" HTML (which is not possible using regex) when the CSS or XPath filters are more suited for the job.
If we make it clear in the docs when it isn't and when it is the right tool for the job, I'm happy to merge this :)
|
Yeah, I was thinking that but was too lazy to think of a good example :) I've borrowed something from another test, and added some doc. |
thp
reviewed
Apr 24, 2024
thp
reviewed
Apr 24, 2024
thp
requested changes
May 18, 2024
docs/source/filters.rst
Outdated
Comment on lines
538
to
539
| XPATH expressions. HTML and XML cannot be parsed properly using regular | ||
| expressions. If the CSS selector or XPATH cannot provide the targeted |
There was a problem hiding this comment.
Could add a link to https://stackoverflow.com/a/1732454/1047040 on "cannot be parsed" for extra entertainment.
Actually using re.finditer so we can apply a repl to the result. This allows users to pick out matches and reformat them in one step. Fixes thp#804 Signed-off-by: James Hewitt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually using re.finditer so we can apply a repl to the result. This allows users to pick out matches and reformat them in one step.
Fixes #804