Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reporters: test report jobs separately #772

Merged
merged 2 commits into from
Oct 25, 2023
Merged

reporters: test report jobs separately #772

merged 2 commits into from
Oct 25, 2023

Conversation

marunjar
Copy link
Contributor

This PR should make the --test-reporter option respect separate flag too.
It's just applying the changes already made with #721 from submit_all method to the submit_one method as well.

fixes #771

I hope this is ok so far, because my python is not the best 😉

@marunjar
reporters: test report jobs separately
6c0d85c 
This PR should make the `--test-reporter` option respect `separate` flag too..
It's just applying the changes already made with thp#721 from `submit_all` method to the `submit_one` method as well.

fixes thp#771

I hope this is ok so far, because my python is not the best 😉
thp
thp requested changes Oct 24, 2023
View reviewed changes
Copy link
Owner

@thp thp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please update CHANGELOG.md, describing your changes.

@marunjar marunjar requested a review from thp October 25, 2023 08:24
@marunjar
Copy link
Contributor Author

Looks good. Please update CHANGELOG.md, describing your changes.

done

@thp thp merged commit 74671c3 into thp:master Oct 25, 2023
5 checks passed
@thp
Copy link
Owner

thp commented Oct 25, 2023

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thp thp thp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--test-reporter option is ignoring separated flag
2 participants
@marunjar @thp