add more details on how to tweak javascript output #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thp
requested changes
Aug 22, 2023
Comment on lines
-322
to
323
| Configuring how long browser jobs wait for pages to load | ||
| Tweaking JavaScript output | ||
| -------------------------------------------------------- |
There was a problem hiding this comment.
I think the title of that section was better before
|
Closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know much about javascript or
playwright, so at least for me it would have been helpful to have some more information here. For example I have been trying to watch a website which does not load properly unless I set the user agent to some common one, and setwait_untiltonetworkidle.