Include Rails environment as task dependency #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1204 It seems `active_support/core_ext/string` is not loaded when calling `suspenders:cleanup:organize_gemfile` on applications **not** created with Suspenders's [application template][]. We could require this file in the class, but instead, we simply use `String#start_with?` to keep things simple. Additionally, we ran `standard` to auto-lint the file. [application template]: https://raw.githubusercontent.com/thoughtbot/suspenders/main/lib/install/web.rb
stevepolitodesign
force-pushed
the
sh-1204
branch
from
df87122 to
39c7d7c
Compare
This reverts commit 39c7d7c.
Closes #1204 The `suspenders:cleanup:organize_gemfile` task was not loading the Rails environment, resulting in the following error: ``` undefined method `starts_with?' for an instance of String ``` This was only happening on existing applications not generated by the [application template][] [application template]: https://raw.githubusercontent.com/thoughtbot/suspenders/main/lib/install/web.rb
stevepolitodesign
changed the title
String#start_with? in OrganizeGemfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1204
The
suspenders:cleanup:organize_gemfiletask was not loading the Railsenvironment, resulting in the following error:
This was only happening on existing applications not generated by the
application template