Skip to content

Roux Components v1#17

Draft
pangolingo wants to merge 139 commits into
mainfrom
component_library_2
Draft

Roux Components v1#17
pangolingo wants to merge 139 commits into
mainfrom
component_library_2

Conversation

@pangolingo

@pangolingo pangolingo commented May 22, 2026

Copy link
Copy Markdown
Contributor

This PR merges the working Roux Components branch into main.

What this adds:

  • 11ty site for documenting Roux Components (in the /site directory)
  • Prettier autoformatting (this automatically acts on Markdown, HTML, and CSS)
    • autoformatting has resulted in adjustments to some core Roux files:
      • markdown formatting (especially bullets)
      • standardizing whitespace in CSS files
        • changing some CSS rules to multiline
  • CI Workflows
    • build/compile the 11ty docs site and publish it to GitHub pages
    • HTML validation
    • a11y checks with AXE
    • snapshot tests to call out CSS/HTML changes that affect how components look
  • Specific core CSS changes to support new components
    • .button:disabled styles
    • new blockquote styles
    • new and adjusted variables for colors and font styles
    • new sizing utilities

garciadanny and others added 30 commits December 11, 2025 10:32
Also started a "sizing" set of utility classes, starting with widths
Uses 11ty to generate a static site for displaying a component library
built with Roux.
- Set pathPrefix to /roux/ in production via SITE_ENV variable
- Update CSS link to use Eleventy's url filter (to set the path prefix in prod)
- Simplify deploy script environment variables

@enatario enatario left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING WORK! TRULY!

I think my only questions are:

  • Can we pair on this to go through it all together? I feel like I have mostly a handle on the breadth but might be good to just do a check all together.
  • It seems like we still might not be compiling the CSS into one file. I wonder how we can achieve that across the board since we push that in our docs. I know we had used lightning css before but it was tricky with this particular setup.

Comment thread site/component-library/alert.md Outdated
Comment thread site/component-library/badge.md

::preview{file="dialogs/basic.html" id="example_basic_modal" tall="true"}::

### Slide-in Drawer Modal

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I might want to update the CSS on this before launch to invert the animation and have it default to no animation and then create an opt-in approach (so using no-preference as the modifier instead of reduce).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread site/component-library/loading-indicator.md Outdated
Comment thread site/component-library/typography.md
Comment thread site/examples/loading-indicator/basic.html
Comment thread site/index.md Outdated
@pangolingo

Copy link
Copy Markdown
Contributor Author

Can we pair on this to go through it all together? I feel like I have mostly a handle on the breadth but might be good to just do a check all together.

Scheduled!

It seems like we still might not be compiling the CSS into one file. I wonder how we can achieve that across the board since we push that in our docs. I know we had used lightning css before but it was tricky with this particular setup.

I will work on this!

- lightning CSS plugin arguments were totally incorrect
- the CSS frm src was not running through lightningcss
@pangolingo

Copy link
Copy Markdown
Contributor Author

@enatario I believe I've address all you suggested changes except for the animation changes to dialogs/modals.

Good call on the CSS bundling - I had LightningCSS set up, but it wasn't configured correctly.

Updates are live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants