Roux Components v1#17
Conversation
Also started a "sizing" set of utility classes, starting with widths
Uses 11ty to generate a static site for displaying a component library built with Roux.
- Set pathPrefix to /roux/ in production via SITE_ENV variable - Update CSS link to use Eleventy's url filter (to set the path prefix in prod) - Simplify deploy script environment variables
enatario
left a comment
There was a problem hiding this comment.
AMAZING WORK! TRULY!
I think my only questions are:
- Can we pair on this to go through it all together? I feel like I have mostly a handle on the breadth but might be good to just do a check all together.
- It seems like we still might not be compiling the CSS into one file. I wonder how we can achieve that across the board since we push that in our docs. I know we had used lightning css before but it was tricky with this particular setup.
|
|
||
| ::preview{file="dialogs/basic.html" id="example_basic_modal" tall="true"}:: | ||
|
|
||
| ### Slide-in Drawer Modal |
There was a problem hiding this comment.
I think I might want to update the CSS on this before launch to invert the animation and have it default to no animation and then create an opt-in approach (so using no-preference as the modifier instead of reduce).
There was a problem hiding this comment.
Scheduled!
I will work on this! |
- lightning CSS plugin arguments were totally incorrect - the CSS frm src was not running through lightningcss
|
@enatario I believe I've address all you suggested changes except for the animation changes to dialogs/modals. Good call on the CSS bundling - I had LightningCSS set up, but it wasn't configured correctly. |
This PR merges the working Roux Components branch into
main.What this adds:
/sitedirectory).button:disabledstylesblockquotestyles