Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty favicon.ico to fix CI #622

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tricknotes
Copy link
Contributor

To avoid ActionController::RoutingError from headless chrome for Rails < 7.2. Like the following:

Failures:

  1) User views ember app using route helper
     Failure/Error: raise ActionController::RoutingError, "No route matches [#{env['REQUEST_METHOD']}] #{env['PATH_INFO'].inspect}"

     ActionController::RoutingError:
       No route matches [GET] "/favicon.ico"

See the failing jobs here.

To avoid `ActionController::RoutingError` from headless chrome for Rails < 7.2.
Like the following:
```
Failures:

  1) User views ember app using route helper
     Failure/Error: raise ActionController::RoutingError, "No route matches [#{env['REQUEST_METHOD']}] #{env['PATH_INFO'].inspect}"

     ActionController::RoutingError:
       No route matches [GET] "/favicon.ico"
```
@tricknotes tricknotes changed the title Add empty favicon.ico Add empty favicon.ico to fix CI Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant