Repository navigation
Conversation
Allow building the new resource from request params so forms can be prefilled, e.g. /admin/customers/new?customer[name]=Bob. Params go through resource_params, so only the dashboard's permitted attributes are used. Requests without params behave as before.
Author
|
If this approach looks good, I'm happy to follow up with the same behaviour for edit. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2723
Allows the
newaction to build the resource from request params, so the form can be prefilled:Use cases:
/admin/cities/new?city[country_id]=1Params go through
resource_params, so only the dashboard's permitted attributes are used. Requests without params behave as before. The check usesparam_key, so namespaced models (Blog::Post→blog_post) work too.Demo app
Creates a Rails app using this branch, with Country / City / Person. The city select on the new person form is filtered by the selected country, which only works because
newnow reads params.