Add primary key tiebreaker for stable sorting #2886
+58
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the stability of sorting in Administrate by introducing a tiebreaker using the primary key.
When ordering by a column, the primary key is now used as a secondary sort key to ensure stable and predictable results.
If the relation does not have a primary key, the tiebreaker is skipped.
Changes:
Motivation:
Without a tiebreaker, sorting by a non-unique column can result in unpredictable order for records with the same value.
This can cause issues such as the order changing on every page load, or the same record appearing on multiple pages when paginating.
By using the primary key as a tiebreaker, we guarantee a stable sort order and prevent these problems.
Please review!