Skip to content

Put revision back in "Changes Planned" when revision in "Request Changes" state is updated #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kavya-chopra wants to merge 4 commits into
base: tm-master
Choose a base branch
from
Open

Put revision back in "Changes Planned" when revision in "Request Changes" state is updated #10

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb856db
stop notifying reviewers if revision is in or state
kavya-chopra Dec 1, 2025
52c6bf0
format fix
kavya-chopra Dec 1, 2025
ff585ef
transfer state to when there are no more rejecting reviewers
kavya-chopra Dec 1, 2025
afe5b2f
update comment
kavya-chopra Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/applications/differential/editor/DifferentialTransactionEditor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,10 +471,10 @@ private function updateReviewStatus(
// reviewer resigns or is removed.
$new_status = DifferentialRevisionStatus::NEEDS_REVIEW;
} else if ($was_revision) {
// This revision was "Needs Revision", but no longer has any rejecting
// This revision no longer has any rejecting
// reviewers. This usually happens after the last rejecting reviewer
// resigns or is removed. Put the revision back in "Needs Review".
$new_status = DifferentialRevisionStatus::NEEDS_REVIEW;
// resigns or is removed. Put the revision in "Changes Planned".
$new_status = DifferentialRevisionStatus::CHANGES_PLANNED;
}

if ($new_status === null) {
Expand Down Expand Up @@ -536,6 +536,10 @@ protected function shouldPublishFeedStory(
protected function shouldSendMail(
PhabricatorLiskDAO $object,
array $xactions) {
// Don't notify reviewers for revisions in "changes planned" / "request changes" state
if ($object->isChangePlanned() || $object->isNeedsRevision()) {
return false;
}
return true;
}

Expand Down