Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unpin the bs4 version, relock #499

Closed
wants to merge 3 commits into from
Closed

unpin the bs4 version, relock #499

wants to merge 3 commits into from

Conversation

goern
Copy link
Member

@goern goern commented Feb 9, 2023

@fridex would you like to update your email in the project file?

Signed-off-by: Christoph Görn [email protected]

@goern
unpin the bs4 version, relock
9770b50 
Signed-off-by: Christoph Görn <[email protected]>
@goern
🐛 fix unit tests
2a669d4 
Signed-off-by: Christoph Görn <[email protected]>
@goern goern requested a review from VannTen February 9, 2023 08:55
@sesheta sesheta added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 9, 2023
@sesheta
Copy link
Member

sesheta commented Feb 9, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from goern by writing /assign @goern in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@goern goern mentioned this pull request Feb 9, 2023
Open
@VannTen
Copy link
Member

VannTen commented Feb 9, 2023

I see nothing wrong.
/lgtm
Any particular reason for the unpin ?

@sesheta sesheta added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Feb 9, 2023
@sesheta
Copy link
Member

sesheta commented Feb 9, 2023

New changes are detected. LGTM label has been removed.

@sesheta sesheta added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 9, 2023
@goern
add tox based tests
a4d06c7 
Signed-off-by: Christoph Görn <[email protected]>
@goern
Copy link
Member Author

goern commented Feb 9, 2023

Any particular reason for the unpin ?

#496

@goern goern closed this by deleting the head repository Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VannTen VannTen Awaiting requested review from VannTen

@codificat codificat Awaiting requested review from codificat

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

Assignees

@VannTen VannTen

Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goern @sesheta @VannTen