Dm update #15
Open
Dm update #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the diag_object
Adds dependency of fms_diag_object_mod to diag_manager_mod
Calls the diag_object register from the regular diag array register if modern is turned on.
…elist Adds namelist variable use_modern_diag
Fixes inquiry for diag_id Sets up diag_yaml_object
Dm register obj
Memory clean up in string conversion function
Updates for DM rewrite foundation
Updates get functions in the diag yaml objects
* adds axis ids to the output buffers
* Adds function recondition_indices() to diag_util_mod * Adds a derived type to fms_diag_bbox_mod
* add openmp test for diag manager
* Return diag_field_not_found if a field is not in the diag_table.yaml when registering fields
* Adds the buffer ids to the diag file object in the register call * add functionality to get the size of the subaxis * Add the field id and the yaml id to the buffer object (with getter and setter functions)
* add the write_data calls * fix the test_flexible_time after the update
* Add getters functions to get the subaxis starting and ending indices * add the fms_diag_reduction_methods_module * adds checks to make sure the indices are passed in correctly to send_data * Sets up fms_diag_do_reduction and adds checks to make sure the input arguments are correct
* refactor the buffer to always save the data as 5d * rename the output buffer type
* change `fileobj` to `fms2io_fileobj`
* Add tests and checks for modern diag manager * add min tests * add tests for time_max * remove test_dm_openmp as it is not necessary anymore
* Add tests and checks
* Add some needed members to the buffer obj, restructure the init_buffer routine to match the old diag manager, adjust tests, add a flag that indicates when done writing data to the diag_file, set output buffers to fill value if masked * inits done_with_math
* change counter allocations and add remap_counter fn
* set up an input buffer object and set up the math in diag_send_complete. Turn openmp tests with multiple threads
* Implement the min and max reduction methods into diag manager, modify tests to test the new diag manager
* initial time_sum added * add unit test --------- Co-authored-by: rem1776 <[email protected]>
* fix diag_send_complete loops and add get_file_ids * initial changes to move mask --------- Co-authored-by: rem1776 <[email protected]>
* Add send_data_4d, update tests to test the new interface
Updates dmUpdate with current main Dec 18 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include a summary of the change and which issue is fixed. Please also include
relevant motivation and context. List any dependencies that are required for
this change.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.
Checklist:
make distcheckpasses