-
Notifications
You must be signed in to change notification settings - Fork 560
Version Packages #7594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #7594
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
## Walkthrough
This update increments patch versions for the `thirdweb`, `nebula`, and `wagmi-adapter` packages and updates their changelogs. It documents a fix in the TransactionWidget component, correcting the payment prompt logic to request only the outstanding balance instead of the full amount. No changes to public APIs were made.
## Changes
| Files/Paths | Change Summary |
|------------------------------------------------------------|------------------------------------------------------------------------------------------------------|
| packages/thirdweb/CHANGELOG.md, package.json | Bumped version to 5.105.16; documented TransactionWidget payment prompt regression fix and theme styling fix. |
| packages/nebula/CHANGELOG.md, package.json | Bumped version to 0.2.16; updated dependency on `thirdweb` to 5.105.16. |
| packages/wagmi-adapter/CHANGELOG.md, package.json | Bumped version to 0.2.113; added empty changelog entry. |
| .changeset/few-moments-add.md | Deleted changelog entry describing the TransactionWidget payment prompt fix. |
## Sequence Diagram(s)
```mermaid
sequenceDiagram
participant User
participant TransactionWidget
participant BalanceChecker
User->>TransactionWidget: Initiate transaction
TransactionWidget->>BalanceChecker: Check user balance
BalanceChecker-->>TransactionWidget: Return current balance
TransactionWidget->>User: Prompt for outstanding balance (difference only)
User->>TransactionWidget: Confirm payment
TransactionWidget->>TransactionWidget: Proceed with transaction Possibly related PRs
Suggested labels
Suggested reviewers
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🔭 Outside diff range comments (2)
packages/nebula/package.json (1)
46-56
: Add explicitsize-limit
budgetsPer internal guidelines (
packages/*/package.json#size-limit
), each package should declare bundle-size budgets next to thesize
script.
@thirdweb-dev/nebula
still lacks that top-level"size-limit": [...]
section, so CI cannot enforce regressions.Example:
"scripts": { "build": "...", "lint": "biome check ./src" }, + "size-limit": [ + { + "path": "dist/esm/index.js", + "limit": "20 kB" + } + ],packages/thirdweb/package.json (1)
310-338
: Declaresize-limit
configuration to match the provided scriptA
size
script is present andsize-limit
is indevDependencies
, but the controlling"size-limit"
field is missing.
Without it the task is a no-op, so bundle growth is unchecked."scripts": { "size": "size-limit", ... }, + "size-limit": [ + { + "path": "dist/esm/exports/thirdweb.js", + "limit": "40 kB" + } + ],
🧹 Nitpick comments (3)
packages/wagmi-adapter/CHANGELOG.md (1)
3-4
: Add substantive notes under the new0.2.113
headingThe empty version header provides no insight to consumers. Even a simple “### Patch Changes – dependency bump only” keeps the log useful and avoids breaking the changelog convention used elsewhere in this file.
packages/nebula/CHANGELOG.md (1)
3-9
: Consider clarifying user-visible impactThe entry only lists updated dependencies. Add one sentence on what the
[email protected]
fix means for Nebula consumers (e.g., “TransactionWidget now requests only the outstanding balance”). It makes the changelog self-contained without forcing readers to chase upstream notes.packages/thirdweb/CHANGELOG.md (1)
3-3
: Consider including a release date for quicker historical lookup
Most changelogs in large repos prefix version headers with the release date (e.g., “## 5.105.16 – 2025-07-02”). Adding it here would improve traceability.-## 5.105.16 +## 5.105.16 – 2025-07-02
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
.changeset/few-moments-add.md
(0 hunks)packages/nebula/CHANGELOG.md
(1 hunks)packages/nebula/package.json
(1 hunks)packages/thirdweb/CHANGELOG.md
(1 hunks)packages/thirdweb/package.json
(1 hunks)packages/wagmi-adapter/CHANGELOG.md
(1 hunks)packages/wagmi-adapter/package.json
(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/few-moments-add.md
🧰 Additional context used
📓 Path-based instructions (1)
`packages/*/package.json`: Track bundle budgets via `package.json#size-limit` De-duplicate dependencies across packages through pnpm workspace hoisting
packages/*/package.json
: Track bundle budgets viapackage.json#size-limit
De-duplicate dependencies across packages through pnpm workspace hoisting
📄 Source: CodeRabbit Inference Engine (CLAUDE.md)
List of files the instruction was applied to:
packages/wagmi-adapter/package.json
packages/thirdweb/package.json
packages/nebula/package.json
🧠 Learnings (7)
📓 Common learnings
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Surface breaking changes prominently in PR descriptions
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.489Z
Learning: Applies to packages/wagmi-adapter/**/*.{ts,tsx} : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.489Z
Learning: Applies to src/wallets/**/*.{ts,tsx} : Support EIP-1193, EIP-5792, EIP-7702 standards in wallet architecture
packages/wagmi-adapter/package.json (4)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.489Z
Learning: Applies to packages/wagmi-adapter/**/*.{ts,tsx} : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Export everything via `exports/` directory, grouped by feature in the public API of the SDK
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Every public symbol must have comprehensive TSDoc with at least one `@example` block that compiles and custom annotation tags (`@beta`, `@internal`, `@experimental`)
Learnt from: MananTank
PR: thirdweb-dev/js#7356
File: apps/nebula/src/app/not-found.tsx:1-1
Timestamp: 2025-06-17T18:30:52.976Z
Learning: In the thirdweb/js project, the React namespace is available for type annotations (like React.FC) without needing to explicitly import React. This is project-specific configuration that differs from typical TypeScript/React setups.
packages/nebula/CHANGELOG.md (1)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Surface breaking changes prominently in PR descriptions
packages/thirdweb/package.json (4)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Export everything via `exports/` directory, grouped by feature in the public API of the SDK
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Surface breaking changes prominently in PR descriptions
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Every public symbol must have comprehensive TSDoc with at least one `@example` block that compiles and custom annotation tags (`@beta`, `@internal`, `@experimental`)
Learnt from: MananTank
PR: thirdweb-dev/js#7356
File: apps/nebula/src/app/not-found.tsx:1-1
Timestamp: 2025-06-17T18:30:52.976Z
Learning: In the thirdweb/js project, the React namespace is available for type annotations (like React.FC) without needing to explicitly import React. This is project-specific configuration that differs from typical TypeScript/React setups.
packages/wagmi-adapter/CHANGELOG.md (1)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.489Z
Learning: Applies to packages/wagmi-adapter/**/*.{ts,tsx} : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
packages/nebula/package.json (3)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Export everything via `exports/` directory, grouped by feature in the public API of the SDK
Learnt from: MananTank
PR: thirdweb-dev/js#7356
File: apps/nebula/src/app/not-found.tsx:1-1
Timestamp: 2025-06-17T18:30:52.976Z
Learning: In the thirdweb/js project, the React namespace is available for type annotations (like React.FC) without needing to explicitly import React. This is project-specific configuration that differs from typical TypeScript/React setups.
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Every public symbol must have comprehensive TSDoc with at least one `@example` block that compiles and custom annotation tags (`@beta`, `@internal`, `@experimental`)
packages/thirdweb/CHANGELOG.md (1)
undefined
<retrieved_learning>
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Surface breaking changes prominently in PR descriptions
</retrieved_learning>
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Lint Packages
- GitHub Check: Unit Tests
- GitHub Check: Build Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (4)
packages/wagmi-adapter/package.json (1)
58-58
: Confirm ancillary updates accompanying the version bumpThe
version
field has been incremented, but nothing else changed.
Please double-check that:
- The new version is referenced in the just-added changelog entry (currently missing detail).
- No additional metadata (e.g.,
size-limit
budgets per repo guidelines) needed to accompany this release.If both points are intentional, feel free to ignore.
packages/nebula/package.json (1)
60-60
: Version bump LGTMPatch version increments properly follow semver; nothing else changed.
No action needed.packages/thirdweb/package.json (1)
407-407
: Patch release looks correctVersion moves from
5.105.15
→5.105.16
, aligning with the regression fix described in the PR. ✅packages/thirdweb/CHANGELOG.md (1)
3-8
: Changelog entry follows existing conventions — LGTM
Header, “Patch Changes” section, and PR/commit references are consistent with prior entries.
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7594 +/- ##
=======================================
Coverage 56.45% 56.45%
=======================================
Files 906 906
Lines 58115 58115
Branches 4226 4226
=======================================
Hits 32810 32810
Misses 25195 25195
Partials 110 110
🚀 New features to boost your workflow:
|
49f0b76
to
04b828d
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/[email protected]
Patch Changes
f33e31a
,592bf6f
]:[email protected]
Patch Changes
#7591
f33e31a
Thanks @gregfromstl! - Fixed a regression that prompted the user to pay the full amount in the TransactionWidget, rather than the difference from their current balance#7589
592bf6f
Thanks @MananTank! - Fix theme in ConnectButton Details Modal Buy screen@thirdweb-dev/[email protected]
PR-Codex overview
This PR focuses on updating version numbers across several packages and includes changelog entries for the
thirdweb
andnebula
packages, detailing recent dependency updates and bug fixes.Detailed summary
.changeset/few-moments-add.md
and.changeset/ten-places-feel.md
.version
inpackages/thirdweb/package.json
from5.105.15
to5.105.16
.version
inpackages/nebula/package.json
from0.2.15
to0.2.16
.version
inpackages/wagmi-adapter/package.json
from0.2.112
to0.2.113
.nebula
with version0.2.16
and dependency updates.thirdweb
with version5.105.16
detailing bug fixes and improvements.Summary by CodeRabbit
Bug Fixes
Chores