-
Notifications
You must be signed in to change notification settings - Fork 558
Make contract webhook addresses mandatory #7544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make contract webhook addresses mandatory #7544
Conversation
Co-authored-by: amine <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe changes enhance validation and user interface cues for a webhook creation form. Schema-level refinements enforce conditional field requirements based on filter type, and error messages are updated for clarity. The UI now visually marks required fields, and validation logic is expanded to include additional fields in certain scenarios. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CreateWebhookModal
participant FormValidator (Schema)
participant UI (FilterDetailsStep)
User->>UI (FilterDetailsStep): Fills in form fields
UI (FilterDetailsStep)->>User: Shows required field indicators
User->>CreateWebhookModal: Submits form
CreateWebhookModal->>FormValidator (Schema): Validates fields (including conditional checks)
alt Validation passes
FormValidator (Schema)-->>CreateWebhookModal: Success
CreateWebhookModal->>User: Proceeds to next step or creates webhook
else Validation fails
FormValidator (Schema)-->>CreateWebhookModal: Error with specific messages
CreateWebhookModal->>User: Displays error (formatted message)
end
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🧰 Additional context used📓 Path-based instructions (2)`**/*.{ts,tsx}`: Write idiomatic TypeScript with explicit function declarations ...
📄 Source: CodeRabbit Inference Engine (CLAUDE.md) List of files the instruction was applied to:
`apps/{dashboard,playground-web}/**/*.{tsx,ts}`: Import UI primitives from `@/co...
📄 Source: CodeRabbit Inference Engine (CLAUDE.md) List of files the instruction was applied to:
🧠 Learnings (4)📓 Common learnings
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/webhooks/components/FilterDetailsStep.tsx (10)
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/webhooks/components/CreateWebhookModal.tsx (10)
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/webhooks/utils/webhookTypes.ts (11)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (7)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7544 +/- ##
=======================================
Coverage 56.52% 56.52%
=======================================
Files 906 906
Lines 57979 57979
Branches 4223 4223
=======================================
Hits 32774 32774
Misses 25097 25097
Partials 108 108
🚀 New features to boost your workflow:
|
size-limit report 📦
|
PR-Codex overview
This PR focuses on enhancing the user interface and validation logic of the webhook creation forms in the dashboard. It adds required indicators to labels and refines the validation schema for contract and from addresses.
Detailed summary
<FormLabel>
forContract Addresses
andFrom Address
.CreateWebhookModal
.webhookFormSchema
to enforce required addresses based on thefilterType
.Summary by CodeRabbit
New Features
Bug Fixes