[SDK] Update to NFT Components#5655
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: f69d1aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kien-ngo
requested review from
MananTank,
edwardysun,
gregfromstl,
jnsdls and
joaquim-verges
as code owners
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5655 +/- ##
==========================================
+ Coverage 50.64% 50.72% +0.07%
==========================================
Files 1091 1092 +1
Lines 57098 57213 +115
Branches 4591 4630 +39
==========================================
+ Hits 28916 29019 +103
- Misses 27466 27478 +12
Partials 716 716
*This pull request uses carry forward flags. Click here to find out more.
|
kien-ngo
force-pushed
the
kien/nft-components-resolver-fn
branch
from
2fc4689 to
5800392
Compare
Contributor
size-limit report 📦
|
kien-ngo
force-pushed
the
kien/nft-components-resolver-fn
branch
from
5800392 to
9e68560
Compare
Contributor
Author
joaquim-verges
approved these changes
Dec 9, 2024
kien-ngo
force-pushed
the
kien/nft-components-resolver-fn
branch
from
dcb17ba to
67d0972
Compare
kien-ngo
force-pushed
the
kien/nft-components-resolver-fn
branch
from
67d0972 to
bc76162
Compare
kien-ngo
force-pushed
the
kien/nft-components-resolver-fn
branch
from
bc76162 to
54a9eca
Compare
Contributor
Merge activity
|
CNCT-2584 - add custom resolver methods - add better test coverage - add caching for the getNFT method - small fix: handling falsy values <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the NFT components in the `thirdweb` library by improving functionality, performance, and test coverage. It introduces custom resolver methods and caching mechanisms, along with fixes for handling falsy values. ### Detailed summary - Added custom resolver methods to `NFTMedia`, `NFTName`, and `NFTDescription`. - Implemented caching for the NFT info getter to improve performance. - Fixed handling of falsy values for NFT media `src`, `name`, and `description`. - Enhanced test coverage by extracting internal logic for testing. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/nft-components-resolver-fn
branch
from
54a9eca to
f69d1aa
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CNCT-2584
PR-Codex overview
This PR focuses on enhancing the NFT components in the
thirdweblibrary by adding custom resolver methods, improving performance through caching, and increasing test coverage.Detailed summary
NFTMedia,NFTName, andNFTDescription.