[SDK] USD balance for AccountBalance #5533

kien-ngo · 2024-11-27T18:12:32Z

PR-Codex overview

This PR introduces significant enhancements to the AccountBalance and ConnectButton components, allowing them to display balances in fiat (USD) and improving formatting options. It also expands utility functions and adds test coverage for these features.

Detailed summary

Added showBalanceInFiat prop to AccountBalance and ConnectButton.
Updated formatFn in AccountBalance to accept AccountBalanceInfo.
Introduced utility functions: formatNumber and shortenLargeNumber.
Expanded test coverage for connected components.
Improved styling and structure in various UI components.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot · 2024-11-27T18:12:36Z

🦋 Changeset detected

Latest commit: 43fbcac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
thirdweb	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

graphite-app · 2024-11-27T18:12:36Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

vercel · 2024-11-27T18:12:38Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 7, 2024 2:38am
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 7, 2024 2:38am
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 7, 2024 2:38am
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 7, 2024 2:38am

kien-ngo · 2024-11-27T18:12:51Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

packages/thirdweb/src/react/web/ui/prebuilt/Account/balance.tsx

github-actions · 2024-11-27T18:15:53Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	41.13 KB (0%)	823 ms (0%)	116 ms (+26.06% 🔺)	939 ms
thirdweb (cjs)	104.48 KB (0%)	2.1 s (0%)	269 ms (-1.93% 🔽)	2.4 s
thirdweb (minimal + tree-shaking)	4.37 KB (0%)	88 ms (0%)	41 ms (+379.58% 🔺)	128 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	18 ms (+155.79% 🔺)	28 ms
thirdweb/react (minimal + tree-shaking)	16.99 KB (0%)	340 ms (0%)	57 ms (+7.17% 🔺)	397 ms

gregfromstl · 2024-11-27T18:17:29Z

Don't forget a changeset but lgtm

codecov · 2024-11-27T18:22:01Z

Codecov Report

Attention: Patch coverage is 81.14754% with 46 lines in your changes missing coverage. Please review.

Project coverage is 50.62%. Comparing base (37aa163) to head (43fbcac).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...hirdweb/src/react/web/ui/ConnectWallet/Details.tsx	72.72%	28 Missing and 2 partials ⚠️
...dweb/src/react/web/ui/prebuilt/Account/balance.tsx	85.41%	13 Missing and 1 partial ⚠️
.../thirdweb/src/react/web/ui/components/CopyIcon.tsx	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5533      +/-   ##
==========================================
+ Coverage   48.97%   50.62%   +1.65%     
==========================================
  Files        1089     1091       +2     
  Lines       56891    57100     +209     
  Branches     4440     4590     +150     
==========================================
+ Hits        27861    28908    +1047     
+ Misses      28325    27478     -847     
- Partials      705      714       +9

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 37aa163
packages	`47.08% <81.14%> (+2.06%)`	⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
packages/thirdweb/src/pay/convert/cryptoToFiat.ts	`100.00% <ø> (+8.51%)`	⬆️
packages/thirdweb/src/pay/convert/fiatToCrypto.ts	`100.00% <100.00%> (+8.88%)`	⬆️
...eact/web/ui/ConnectWallet/screens/ReceiveFunds.tsx	`89.06% <100.00%> (+84.06%)`	⬆️
...c/react/web/ui/ConnectWallet/screens/SendFunds.tsx	`41.03% <100.00%> (+37.83%)`	⬆️
.../thirdweb/src/react/web/ui/components/Skeleton.tsx	`96.15% <100.00%> (+0.15%)`	⬆️
packages/thirdweb/src/utils/formatNumber.ts	`100.00% <ø> (ø)`
packages/thirdweb/src/utils/shortenLargeNumber.ts	`100.00% <100.00%> (ø)`
.../thirdweb/src/react/web/ui/components/CopyIcon.tsx	`78.12% <33.33%> (+68.12%)`	⬆️
...dweb/src/react/web/ui/prebuilt/Account/balance.tsx	`83.84% <85.41%> (+3.45%)`	⬆️
...hirdweb/src/react/web/ui/ConnectWallet/Details.tsx	`53.86% <72.72%> (+22.67%)`	⬆️

... and 29 files with indirect coverage changes

packages/thirdweb/src/exports/react.ts

packages/thirdweb/src/react/web/ui/prebuilt/Account/balance.tsx

joaquim-verges · 2024-12-07T00:19:09Z

packages/thirdweb/src/react/web/ui/ConnectWallet/screens/SendFunds.test.tsx

+
+const client = TEST_CLIENT;
+
+describe("SendFunds screen", () => {


thank you for the tests! 76% coverage really nice 👌

yesser, just trying to push to 80% so we can get this PR merged!

kien-ngo · 2024-12-07T01:34:51Z

Merge activity

Dec 6, 8:34 PM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
Dec 6, 9:28 PM EST: A user added this pull request to the Graphite merge queue.
Dec 6, 9:40 PM EST: A user merged this pull request with the Graphite merge queue.

CNCT-2494  --- ## PR-Codex overview This PR enhances the `AccountBalance` and `ConnectButton` components to support displaying balances in fiat currency (currently only USD). It also introduces new utility functions and improves test coverage across various components. ### Detailed summary - Added `showBalanceInFiat` prop to `AccountBalance` and `ConnectButton`. - Updated `formatFn` in `AccountBalance` to accept an object of type `AccountBalanceInfo`. - Introduced `shortenLargeNumber` and `formatNumber` utility functions. - Improved tests for `ConnectButton`, `AccountBalance`, and related components. - Enhanced rendering logic for displaying balances in both token and fiat. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Nov 27, 2024

kien-ngo mentioned this pull request Nov 27, 2024

[SDK] Add 2 new Pay functions: convertFiatToCrypto and convertCryptoToFiat #5457

Merged

kien-ngo changed the title ~~update~~ [Experiment] USD balance for AccountBalance Nov 27, 2024

kien-ngo marked this pull request as ready for review November 27, 2024 18:13

kien-ngo requested review from joaquim-verges, gregfromstl, MananTank, jnsdls and edwardysun as code owners November 27, 2024 18:13

graphite-app bot reviewed Nov 27, 2024

View reviewed changes

packages/thirdweb/src/react/web/ui/prebuilt/Account/balance.tsx Outdated Show resolved Hide resolved

vercel bot deployed to Preview – wallet-ui November 27, 2024 18:15 View deployment

vercel bot deployed to Preview – thirdweb_playground November 27, 2024 18:15 View deployment

kien-ngo force-pushed the kien/account-balance-in-usd branch from 1bf3114 to c2329af Compare November 27, 2024 18:16

vercel bot deployed to Preview – wallet-ui November 27, 2024 18:18 View deployment

vercel bot deployed to Preview – thirdweb_playground November 27, 2024 18:19 View deployment

vercel bot deployed to Preview – docs-v2 November 27, 2024 18:29 View deployment

vercel bot deployed to Preview – thirdweb-www November 27, 2024 18:35 View deployment

kien-ngo force-pushed the kien/pay-convert-endpoints branch from dcd6b94 to 07afcee Compare November 28, 2024 13:10

kien-ngo force-pushed the kien/account-balance-in-usd branch from c2329af to 4b66fbd Compare November 28, 2024 13:10

kien-ngo mentioned this pull request Nov 28, 2024

[Playground] Feature: Headless components #5535

Merged

graphite-app bot reviewed Nov 28, 2024

View reviewed changes

packages/thirdweb/src/exports/react.ts Outdated Show resolved Hide resolved

graphite-app bot reviewed Nov 28, 2024

View reviewed changes

packages/thirdweb/src/react/web/ui/prebuilt/Account/balance.tsx Outdated Show resolved Hide resolved

joaquim-verges reviewed Dec 7, 2024

View reviewed changes

kien-ngo force-pushed the kien/account-balance-in-usd branch from 43aeac4 to d54a6d0 Compare December 7, 2024 02:01

vercel bot deployed to Preview – wallet-ui December 7, 2024 02:04 View deployment

vercel bot deployed to Preview – thirdweb_playground December 7, 2024 02:04 View deployment

vercel bot deployed to Preview – docs-v2 December 7, 2024 02:09 View deployment

vercel bot deployed to Preview – thirdweb-www December 7, 2024 02:10 View deployment

kien-ngo force-pushed the kien/account-balance-in-usd branch from d54a6d0 to a6c781c Compare December 7, 2024 02:10

vercel bot deployed to Preview – wallet-ui December 7, 2024 02:14 View deployment

vercel bot deployed to Preview – thirdweb_playground December 7, 2024 02:14 View deployment

vercel bot deployed to Preview – thirdweb-www December 7, 2024 02:20 View deployment

vercel bot deployed to Preview – docs-v2 December 7, 2024 02:22 View deployment

kien-ngo force-pushed the kien/account-balance-in-usd branch from a6c781c to f0111e7 Compare December 7, 2024 02:25

vercel bot deployed to Preview – wallet-ui December 7, 2024 02:26 View deployment

vercel bot deployed to Preview – docs-v2 December 7, 2024 02:27 View deployment

vercel bot deployed to Preview – thirdweb_playground December 7, 2024 02:28 View deployment

vercel bot deployed to Preview – thirdweb-www December 7, 2024 02:28 View deployment

kien-ngo force-pushed the kien/account-balance-in-usd branch from f0111e7 to 43fbcac Compare December 7, 2024 02:29

vercel bot deployed to Preview – wallet-ui December 7, 2024 02:30 View deployment

vercel bot deployed to Preview – thirdweb_playground December 7, 2024 02:30 View deployment

vercel bot deployed to Preview – docs-v2 December 7, 2024 02:31 View deployment

vercel bot deployed to Preview – thirdweb-www December 7, 2024 02:38 View deployment

graphite-app bot merged commit 43fbcac into main Dec 7, 2024
32 checks passed

graphite-app bot deleted the kien/account-balance-in-usd branch December 7, 2024 02:40

vercel bot deployed to Production – wallet-ui December 7, 2024 02:42 View deployment

jnsdls mentioned this pull request Dec 7, 2024

Version Packages #5650

Merged

vercel bot deployed to Production – docs-v2 December 7, 2024 02:42 View deployment

vercel bot deployed to Production – thirdweb_playground December 7, 2024 02:42 View deployment

vercel bot deployed to Production – thirdweb-www December 7, 2024 02:49 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SDK] USD balance for AccountBalance #5533

[SDK] USD balance for AccountBalance #5533

kien-ngo commented Nov 27, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Nov 27, 2024 •

edited

Loading

graphite-app bot commented Nov 27, 2024

vercel bot commented Nov 27, 2024 •

edited

Loading

kien-ngo commented Nov 27, 2024 •

edited

Loading

github-actions bot commented Nov 27, 2024 •

edited

Loading

gregfromstl commented Nov 27, 2024

codecov bot commented Nov 27, 2024 •

edited

Loading

joaquim-verges Dec 7, 2024

kien-ngo Dec 7, 2024

kien-ngo commented Dec 7, 2024 •

edited by graphite-app bot

Loading


		const client = TEST_CLIENT;

		describe("SendFunds screen", () => {

[SDK] USD balance for AccountBalance #5533

[SDK] USD balance for AccountBalance #5533

Conversation

kien-ngo commented Nov 27, 2024 • edited by pr-codex bot Loading

PR-Codex overview

Detailed summary

changeset-bot bot commented Nov 27, 2024 • edited Loading

🦋 Changeset detected

graphite-app bot commented Nov 27, 2024

Your org has enabled the Graphite merge queue for merging into main

vercel bot commented Nov 27, 2024 • edited Loading

kien-ngo commented Nov 27, 2024 • edited Loading

github-actions bot commented Nov 27, 2024 • edited Loading

size-limit report 📦

gregfromstl commented Nov 27, 2024

codecov bot commented Nov 27, 2024 • edited Loading

Codecov Report

joaquim-verges Dec 7, 2024

Choose a reason for hiding this comment

kien-ngo Dec 7, 2024

Choose a reason for hiding this comment

kien-ngo commented Dec 7, 2024 • edited by graphite-app bot Loading

Merge activity

kien-ngo commented Nov 27, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Nov 27, 2024 •

edited

Loading

vercel bot commented Nov 27, 2024 •

edited

Loading

kien-ngo commented Nov 27, 2024 •

edited

Loading

github-actions bot commented Nov 27, 2024 •

edited

Loading

codecov bot commented Nov 27, 2024 •

edited

Loading

kien-ngo commented Dec 7, 2024 •

edited by graphite-app bot

Loading