fix: respect bundlerUrl in waitForUserReceipt #5277
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 58fb28d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @joaquim-verges and the rest of your teammates on |
size-limit report 📦
|
| @@ -624,7 +624,7 @@ async function _sendUserOp(args: { | |||
| }); | |||
| // wait for tx receipt rather than return the userOp hash | |||
| const receipt = await waitForUserOpReceipt({ | |||
| ...options, | |||
| ...bundlerOptions, | |||
There was a problem hiding this comment.
Are we losing anything here from options? Would it be better to do:
...options,
...bundlerOptions,
userOpHash
so all the same values are still included just in case?
There was a problem hiding this comment.
No, should just be by doer options here. In fact I might change it to be fully explicit instead of spreading
joaquim-verges
force-pushed
the
fix_respect_bundlerUrl_in_waitForUserReceipt
branch
from
fc96e80
to
bf88465
Compare
joaquim-verges
force-pushed
the
fix_respect_bundlerUrl_in_waitForUserReceipt
branch
from
bf88465
to
63c6b5b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5277 +/- ##
==========================================
+ Coverage 45.37% 45.44% +0.07%
==========================================
Files 1067 1067
Lines 55451 55459 +8
Branches 3992 4009 +17
==========================================
+ Hits 25161 25206 +45
+ Misses 29599 29562 -37
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more.
|
joaquim-verges
force-pushed
the
fix_respect_bundlerUrl_in_waitForUserReceipt
branch
from
63c6b5b
to
421b671
Compare
Merge activity
|
## Problem solved Fixes CNCT-2217 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on improving the `thirdweb` package by updating configurations, modifying wallet functionalities, enhancing chain checks, and refining tests for wallet balance functionality. ### Detailed summary - Updated `limit` in `.size-limit.json` from `500 B` to `600 B`. - Changed `options` to `bundlerOptions` in `waitForUserOpReceipt` call. - Added additional chain IDs in `isZkSyncChain.ts`. - Implemented fallback to RPC stack check in `isZkSyncChain.ts`. - Renamed test case from "should work for un-named token" to "should work for native currency" in `getWalletBalance.test.ts`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
joaquim-verges
force-pushed
the
fix_respect_bundlerUrl_in_waitForUserReceipt
branch
from
421b671
to
58fb28d
Compare
graphite-app
bot
deleted the
fix_respect_bundlerUrl_in_waitForUserReceipt
branch
Problem solved
Fixes CNCT-2217
PR-Codex overview
This PR focuses on improving the
thirdwebpackage by updating configurations, enhancing transaction receipt handling, and refining chain identification logic.Detailed summary
limitin.size-limit.jsonfrom500 Bto600 B.optionstobundlerOptionsinwaitForUserOpReceipt.isZkSyncChain.tsand implemented a fallback mechanism to check the stack type.getWalletBalance.test.ts.