-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UI for Mintable, Royalty, Claimable, Transferable, BatchMetadata and OpenEdition modules #5219
base: modules
Are you sure you want to change the base?
Conversation
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## modules #5219 +/- ##
========================================
Coverage 45.29% 45.29%
========================================
Files 1068 1068
Lines 55380 55380
Branches 3975 3975
========================================
Hits 25082 25082
Misses 29606 29606
Partials 692 692
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Merge activity
|
<FormItem className="flex-1"> | ||
<FormLabel>Description</FormLabel> | ||
<FormControl> | ||
<Input {...field} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a Textarea and not an Input
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on enhancing the functionality and UI of various components within the dashboard, particularly around contract modules, forms, and metadata handling. It introduces new features, improves existing ones, and refines the user experience.
Detailed summary
publisherAddress
default value inModuleForm
.addressSchema
for address validation inzod-schemas
.InstalledModulesTable
withuseAllModuleContractInfo
.ModuleCard
to useModuleInstance
for rendering.PropertiesFormControl
andNFTMediaFormGroup
.OpenEditionMetadataModule
andBatchMetadataModule
.package.json
.