Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI for Mintable, Royalty, Claimable, Transferable, BatchMetadata and OpenEdition modules #5219

Open
wants to merge 49 commits into
base: modules
Choose a base branch
from

Conversation

GWSzeto
Copy link
Contributor

@GWSzeto GWSzeto commented Oct 29, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the functionality and UI of various components within the dashboard, particularly around contract modules, forms, and metadata handling. It introduces new features, improves existing ones, and refines the user experience.

Detailed summary

  • Added publisherAddress default value in ModuleForm.
  • Introduced addressSchema for address validation in zod-schemas.
  • Enhanced InstalledModulesTable with useAllModuleContractInfo.
  • Updated ModuleCard to use ModuleInstance for rendering.
  • Improved layout and functionality in various forms, including PropertiesFormControl and NFTMediaFormGroup.
  • Implemented loading skeletons for better UX during data fetching.
  • Added new components for handling metadata, including OpenEditionMetadataModule and BatchMetadataModule.
  • Updated package dependencies in package.json.

The following files were skipped due to too many changes: apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/modules/components/Transferable.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/modules/components/Mintable.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/modules/components/Royalty.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/modules/components/Claimable.tsx, pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Oct 29, 2024

⚠️ No Changeset found

Latest commit: ca659ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Oct 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 0:02am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 5, 2024 0:02am
thirdweb_playground ⬜️ Skipped (Inspect) Nov 5, 2024 0:02am
wallet-ui ⬜️ Skipped (Inspect) Nov 5, 2024 0:02am

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (3658b3f) to head (ca659ba).

Additional details and impacted files
@@           Coverage Diff            @@
##           modules    #5219   +/-   ##
========================================
  Coverage    45.29%   45.29%           
========================================
  Files         1068     1068           
  Lines        55380    55380           
  Branches      3975     3975           
========================================
  Hits         25082    25082           
  Misses       29606    29606           
  Partials       692      692           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from b2d4446
packages 40.30% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Oct 29, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 678 ms (+49.43% 🔺) 1.6 s
thirdweb (cjs) 102.91 KB (0%) 2.1 s (0%) 1.7 s (+38.12% 🔺) 3.8 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 90 ms (+66.56% 🔺) 186 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 127 ms (+1285.31% 🔺) 137 ms
thirdweb/react (minimal + tree-shaking) 17.38 KB (-0.04% 🔽) 348 ms (-0.04% 🔽) 193 ms (+121.88% 🔺) 540 ms

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 29, 2024 17:24 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 29, 2024 17:24 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 29, 2024 17:24 Inactive
@MananTank MananTank changed the title Mintable module Add Mintable and Transerable module UI Oct 29, 2024
@MananTank MananTank added the merge-queue Adds the pull request to Graphite's merge queue. label Oct 29, 2024
MananTank
MananTank previously approved these changes Oct 29, 2024
Copy link
Member

MananTank commented Oct 29, 2024

Merge activity

  • Oct 29, 1:36 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 29, 1:36 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 29, 1:37 PM EDT: The Graphite merge queue couldn't merge this PR because it was in draft mode.

@MananTank MananTank marked this pull request as draft October 29, 2024 17:36
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Oct 29, 2024
@MananTank MananTank changed the title Add Mintable and Transerable module UI Add Mintable and Transferable module UI Oct 29, 2024
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 4, 2024 22:13 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 4, 2024 22:29 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 4, 2024 22:29 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 4, 2024 22:29 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 4, 2024 23:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 4, 2024 23:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 4, 2024 23:43 Inactive
<FormItem className="flex-1">
<FormLabel>Description</FormLabel>
<FormControl>
<Input {...field} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a Textarea and not an Input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants