Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLOCK-40: Implement chainsaw in NFT assets view #4006

Conversation

iuwqyir
Copy link
Contributor

@iuwqyir iuwqyir commented Aug 8, 2024

Problem solved

Adds NFT balance fetch from Chainsaw


PR-Codex overview

The focus of this PR is to refactor NFT fetching logic and update UI components in the ConnectWallet feature.

Detailed summary

  • Added useGetOwnedNFTs hook for fetching owned NFTs
  • Updated NFT fetching logic in ViewNFTsContent
  • Removed unused functions and imports
  • Improved NFT card rendering logic for multiple NFTs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Aug 8, 2024

Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ❌ Failed (Inspect) Aug 9, 2024 8:31am
thirdweb_playground ❌ Failed (Inspect) Aug 9, 2024 8:31am
thirdweb-www ❌ Failed (Inspect) Aug 9, 2024 8:31am
wallet-ui ❌ Failed (Inspect) Aug 9, 2024 8:31am

Copy link

changeset-bot bot commented Aug 8, 2024

⚠️ No Changeset found

Latest commit: c292dc8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

iuwqyir commented Aug 8, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @iuwqyir and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the TS SDK Involves changes to the v5 TypeScript SDK. label Aug 8, 2024
Copy link
Contributor

github-actions bot commented Aug 8, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.11 KB (0%) 883 ms (0%) 313 ms (+65.92% 🔺) 1.2 s
thirdweb (cjs) 92.35 KB (0%) 1.9 s (0%) 404 ms (+32.81% 🔺) 2.3 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 178 ms (+2882.05% 🔺) 275 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 52 ms (+1846.07% 🔺) 62 ms
thirdweb/react (minimal + tree-shaking) 13.65 KB (0%) 274 ms (0%) 58 ms (+104.61% 🔺) 331 ms

@iuwqyir iuwqyir marked this pull request as ready for review August 8, 2024 15:31
Copy link

graphite-app bot commented Aug 8, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TS SDK Involves changes to the v5 TypeScript SDK.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants