-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add Engine Account support #3584
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org requires the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
TODO: add tests |
CodSpeed Performance ReportMerging #3584 will not alter performanceComparing Summary
|
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3584 +/- ##
==========================================
- Coverage 62.32% 62.19% -0.14%
==========================================
Files 963 964 +1
Lines 74814 74995 +181
Branches 3772 3767 -5
==========================================
+ Hits 46631 46644 +13
- Misses 27498 27668 +170
+ Partials 685 683 -2
*This pull request uses carry forward flags. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give this a spin! Cc @arcoraven @d4mr @farhanW3
3575566
to
12286c3
Compare
12286c3
to
569d60b
Compare
569d60b
to
2620d7a
Compare
2620d7a
to
035fda8
Compare
035fda8
to
1fdbdca
Compare
PR-Codex overview
The focus of this PR is to export
EngineAccountOptions
andengineAccount
fromwallets/engine-account.js
towallets.ts
.Detailed summary
EngineAccountOptions
andengineAccount
fromwallets/engine-account.js
towallets.ts
engineAccount
function to create an engine account with various methods for transactions, message signing, and typed data signing