Skip to content

Fix paymaster-less v0.7 AA encoding #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Apr 3, 2025

Fixes TOOL-3952


PR-Codex overview

This PR focuses on improving the handling of the Paymaster in the PackedUserOperation. It introduces conditional logic to handle cases where the Paymaster is null or set to a specific address, ensuring the PaymasterAndData is properly initialized.

Detailed summary

  • Introduced a conditional check for userOp.Paymaster.
  • If Paymaster is null or a specific address, PaymasterAndData is set to an empty array.
  • Otherwise, the Paymaster and related data are processed and copied to paymasterAndDataBuffer.
  • PackedUserOperation is created based on the conditional logic.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Apr 3, 2025

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 60.52632% with 15 lines in your changes missing coverage. Please review.

Project coverage is 61.98%. Comparing base (59f7ed8) to head (efdb859).

Files with missing lines Patch % Lines
...irdweb/Thirdweb.Wallets/SmartWallet/SmartWallet.cs 60.52% 14 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   62.17%   61.98%   -0.19%     
==========================================
  Files          41       41              
  Lines        6157     6174      +17     
  Branches      795      796       +1     
==========================================
- Hits         3828     3827       -1     
- Misses       2152     2169      +17     
- Partials      177      178       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xFirekeeper 0xFirekeeper merged commit 9a19b08 into main Apr 3, 2025
3 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/fix-v7-aa-wo-sponsorship branch April 3, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants