Skip to content

[Beta] ThirdwebWallet - An All Encompassing Wallet #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Mar 14, 2025

Test Only
Attempt to create an ultimate 7702 account, with the best dx possible.
Eventually will have an implied executor, improving creation DX.

Closes TOOL-3195


PR-Codex overview

This PR introduces new functionalities and updates to enhance the Thirdweb wallet system, particularly focusing on session key management and transaction receipt handling. It also refines the structure of session-related classes and methods.

Detailed summary

  • Added MINIMAL_ACCOUNT_7702 constant in Constants.cs.
  • Replaced AccountAbstraction.SessionKeyParams_7702 with AccountAbstraction.SessionSpec in EIP712.cs.
  • Updated SignTypedDataV4 methods in PrivateKeyWallet.cs to use new encoding logic.
  • Changed IsReferenceType method visibility to internal in Utils.cs.
  • Introduced WaitForTransactionReceipt method in Utils.cs for transaction receipt handling.
  • Refactored session-related classes (SessionSpec, CallSpec, TransferSpec, UsageLimit, Constraint) in AATypes.cs.
  • Enhanced ThirdwebWallet creation logic to validate session key signers.
  • Updated transaction execution logic in ThirdwebWallet to utilize session keys.
  • Modified the EIP712Encoder class to support new encoding methods for typed data.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Test Only
Attempt to create an ultimate 7702 account, with the best dx possible.
Eventually will have an implied executor, improving creation DX.

Closes TOOL-3195
Copy link

linear bot commented Mar 14, 2025

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 31.63265% with 268 lines in your changes missing coverage. Please review.

Project coverage is 63.39%. Comparing base (3c9f17a) to head (0b4cb47).

Files with missing lines Patch % Lines
Thirdweb/Thirdweb.Wallets/ThirdwebWallet.cs 0.00% 111 Missing ⚠️
Thirdweb/Thirdweb.Wallets/EIP712Encoder.cs 60.20% 75 Missing and 3 partials ⚠️
Thirdweb/Thirdweb.Utils/Utils.cs 0.00% 45 Missing ⚠️
...SmartWallet/Thirdweb.AccountAbstraction/AATypes.cs 0.00% 25 Missing ⚠️
Thirdweb/Thirdweb.Wallets/EIP712.cs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   65.33%   63.39%   -1.94%     
==========================================
  Files          38       40       +2     
  Lines        5859     6232     +373     
  Branches      760      787      +27     
==========================================
+ Hits         3828     3951     +123     
- Misses       1854     2102     +248     
- Partials      177      179       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants