Skip to content

Conversation

@joschu
Copy link
Collaborator

@joschu joschu commented Nov 23, 2025

No description provided.

@joschu joschu marked this pull request as ready for review November 23, 2025 07:12
@claude
Copy link

claude bot commented Nov 23, 2025

Claude finished @joschu's task —— View job


Code Review Complete ✅

Todo List

  • Read pyproject.toml to understand current structure
  • Analyze the changes made in this PR
  • Verify all existing extras are included in 'all' group
  • Check for syntax and structural issues
  • Provide comprehensive review feedback

Review Summary

This PR adds an all extras group to pyproject.toml that bundles all optional dependency groups together. The implementation is correct and ready to merge

Changes Made

File: pyproject.toml (lines 59-65)

Added a new all extras group that includes:

  • vector-search (chromadb, google-genai, huggingface_hub)
  • wandb (wandb)
  • neptune-scale (neptune-scale>=0.27.0)
  • trackio (trackio<1.0.0)
  • verifiers (verifiers, openai)

Review Findings

✅ Strengths

  1. Complete coverage: All existing optional dependency groups are correctly included in the all group
  2. Correct syntax: Uses the proper PEP 508 extras reference syntax (tinker_cookbook[group-name])
  3. Consistent formatting: Follows the existing code style with proper indentation and list formatting
  4. User-friendly: Provides a convenient way for users to install all extras with pip install -e .[all]
  5. Standard practice: This is a common pattern in Python packages (e.g., pip install pytest[all])

📝 Notes

  • The dev group is intentionally excluded from all, which is correct since development dependencies are typically installed separately
  • All version constraints and package names are preserved through the reference mechanism

Recommendation

Approve and merge - This is a straightforward, well-implemented addition that improves the user experience.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants