Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update npm start command #204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update npm start command #204

wants to merge 1 commit into from

Conversation

rayng86
Copy link

@rayng86 rayng86 commented Aug 9, 2021

npm script is broken and gives an error when you try running it on you local environment.

Error Message when running npm start:

Error: Cannot find module 'webpack-cli/bin/config-yargs'
Require stack:
../react-a11y-announcer/node_modules/webpack-dev-server/bin/webpack-dev-server.js

It looks like we are on "webpack-cli": "^4.1.0",, which now requires an updated command for npm start to work properly.

The fix was to change the following in package.json:

"scripts": { "start": "webpack-dev-server" }

to

"scripts": { "start": "webpack serve" }

@think-john
Copy link

Dear @brendanmckeown , I added you as a reviewer because Raymond here (a new member of the Comcast Corporate team) mentioned that he had some observations about this repo, and I told him "by all means, submit a pull request." So here is that pull request!

Do you think there is someone else that should get this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants