Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/node 10 update #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

brendanmckeown
Copy link
Collaborator

@brendanmckeown brendanmckeown commented Nov 12, 2020

Summary

This PR updates the main branch with the Node 10 image update that was released and tagged as 0.3.0.

Will this affect me?

Probably not.

If you are using this Docker image in a project build or pipeline, check to see what image tag you are using. If you do not indicate a tag (thinkcompany/docker-node-deploy), which is the same as using the latest tag (thinkcompany/docker-node-deploy:latest), you should change this to use a specific tag. Using the latest tag is not recommended because the image can change whenever an untagged build is published. When you use a specific tag for this image, you can ensure the version of Node being installed in your build container is not going to change.

From https://kubernetes.io/docs/concepts/configuration/overview/#container-images

Note: You should avoid using the :latest tag when deploying containers in production as it is harder to track which version of the image is running and more difficult to roll back properly.

@think-john
Copy link

Some of our older Fractal-based build kits seem to go as high as Node 8 without breaking, but if you try to build them on 10, they will fail. For instance, the Merck Connect Build Kit specifies node 8.17.0:

image
https://app.netlify.com/sites/merck-buildkit/settings/deploys

HOWEVER, the particular example I've given above does not (as far as I know) use the Think Company docker image -- it uses the Netlify stock image, which is Ubuntu Xenial 16.04.

So now that I think about it, I think that if this breaks anything, those things are old and probably should be found and updated anyhow. In short, I like this and think we should do it!

@brendanmckeown
Copy link
Collaborator Author

brendanmckeown commented Nov 12, 2020

Some of our older Fractal-based build kits seem to go as high as Node 8 without breaking, but if you try to build them on 10, they will fail. For instance, the Merck Connect Build Kit specifies node 8.17.0:

image
https://app.netlify.com/sites/merck-buildkit/settings/deploys

HOWEVER, the particular example I've given above does not (as far as I know) use the Think Company docker image -- it uses the Netlify stock image, which is Ubuntu Xenial 16.04.

So now that I think about it, I think that if this breaks anything, those things are old and probably should be found and updated anyhow. In short, I like this and think we should do it!

I found that this Merck build kit uses this Docker image and does not specify a tag.
https://bitbucket.org/thinkcompany/merck_sso-buildkit/src/master/bitbucket-pipelines.yml

To my understanding, merging this PR will not have any impact on that build configuration – nor the latest tag for this image. But I would recommend changing that configuration and any others to specify a tag to ensure the correct version of Node is being installed for the project.

Available tags:
0.1.0: Node 6
0.2.0: Node 8
0.3.0: Node 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants