Use tanstack table for Competitors #10778
Conversation
There was a problem hiding this comment.
Okay, I see your point much more clearly now. The configuration is indeed cumbersome, and especially in terms of footer counts the setup is much more complicated than I anticipated.
I'll leave it up to you whether you want to use it and merge this PR or if you prefer to discard it.
| ) : ( | ||
| info.getValue() | ||
| ), |
There was a problem hiding this comment.
I don't get this with regards to the ternary condition. If getValue is truthy, you return an <a> link, but if it's falsey you just return... that falsey value explicitly? Why not just info.getValue() && (<a>)?
| } ${ | ||
| I18n.t( | ||
| 'registrations.registration_info_people.person', | ||
| { count: info.table.getCoreRowModel().rows.length }, |
There was a problem hiding this comment.
You can just pass registrationCount here.
| { | ||
| id: 'country', | ||
| header: I18n.t('activerecord.attributes.user.country_iso2'), | ||
| accessorFn: (row) => countries.byIso2[row.user.country.iso2].name, |
There was a problem hiding this comment.
Clever, I think I should copy that in my Records PR :D
| const { countryCount } = getTotals( | ||
| info.table.getCoreRowModel().rows.map((row) => row.original), | ||
| eventIds, | ||
| ); |
There was a problem hiding this comment.
Hm, this is indeed quite unintuitive.
| } | ||
| }, | ||
| ...eventIds.map((id) => ({ | ||
| id, |
There was a problem hiding this comment.
Maybe something like event-${id}?
| <Table.Footer> | ||
| {table.getFooterGroups().map(footerGroup => ( | ||
| <Table.Row key={footerGroup.id}> | ||
| {footerGroup.headers.map(header => ( |
There was a problem hiding this comment.
Do they really call this footerGroup.headers?!
| ))} | ||
| </Table.Header> | ||
| <Table.Body> | ||
| {table.getSortedRowModel().rows.length > 0 ? ( |
There was a problem hiding this comment.
Can you return early if no columns are found?
See slack discussion about my concerns.