WCA Live Result Admin #2: Opening Rounds #10777
Conversation
There was a problem hiding this comment.
Not much to discuss here, but while we're at it we should probably find a better name for this whole "open" concept.
It worked while WCA Live was separate, because ever special term had to be interpreted with regards to live results entry. Now that we're moving the functionality back into the monolith, "open" suddenly is a bit too generic. Open for what? For registration? For complaints? For editing?
Suggestions:
scoretaking_openscoretaking_activelive_results_opendata_entry_ongoing- permutations of the prefixes and suffixes above
| round = Round.find(round_id) | ||
|
|
||
| if round.is_open? | ||
| flash[:danger] = "Round is already open" |
There was a problem hiding this comment.
I'm not sure we should be working with flash messages at this point.
| def round_can_be_opened? | ||
| return false if is_open | ||
| return true if number == 1 | ||
| previous_round = Round.joins(:competition_event).find_by(competition_event: { competition_id: competition_event.competition_id, event_id: event.id }, number: number - 1) | ||
| previous_round.score_taking_done? | ||
| end |
There was a problem hiding this comment.
Isn't this just number == 1 || (!is_open && ...)?
There was a problem hiding this comment.
no. that would always return true for rounds with number == 1. But these are not openable if they are already opened. it actually used to be this
def round_can_be_opened?
return false if is_open
return !is_open if number == 1
previous_round = Round.joins(:competition_event).find_by(competition_event: { competition_id: competition_event.competition_id, event_id: event.id }, number: number - 1)
previous_round.score_taking_done?
end
but that !is_open is redundant after the first check
Has the Admin schedule where you can open rounds. Will add some tests to this once the db pr is merged