Bring registration emails in line with v2 statuses #10720
Conversation
| @@ -15,7 +15,6 @@ | |||
| let(:registration) { FactoryBot.create(:registration, user: french_user, competition: competition_with_organizers) } | |||
| let(:mail_new) { RegistrationsMailer.notify_registrant_of_new_registration(registration) } | |||
| let(:mail_accepted) { RegistrationsMailer.notify_registrant_of_accepted_registration(registration) } | |||
| let(:mail_pending) { RegistrationsMailer.notify_registrant_of_pending_registration(registration) } | |||
There was a problem hiding this comment.
Why is this disappearing without replacement? There is notify_registrant_of_waitlisted_registration now, which you could well put here.
There was a problem hiding this comment.
The header test seems to rely on a french translation key which we don't have - should I add it in in order for the test to pass? I can find some french people to consult with
| @@ -164,6 +164,49 @@ | |||
| registration = Registration.find_by(user_id: user.id, competition_id: favourites_reg.competition.id) | |||
| expect(registration.event_ids.sort).to eq(new_event_ids.sort) | |||
| end | |||
|
|
|||
| it 'user gets registration email if they cancel and re-register' do | |||
| perform_enqueued_jobs do | |||
There was a problem hiding this comment.
You only need to wrap perform_enqueued_jobs around those parts of your test that actually enqueue the job. So in this case, it would probably be the patch below.
There was a problem hiding this comment.
Another option is to just write your test as usual, and call perform_enqueued_jobs directly as a method to "flush" the job queue, without passing a do block
| end | ||
|
|
||
| it 'user gets registration email if they were rejected and get moved to pending' do | ||
| perform_enqueued_jobs do |
This addresses a few different issues:
TODO: