Fix results DNF/DNS quirk

thewca · Feb 5, 2025 · e299904 · e299904
1 parent f2ced0c
commit e299904
Showing 1 changed file with 15 additions and 7 deletions.
diff --git a/app/webpacker/components/Results/TableColumns.jsx b/app/webpacker/components/Results/TableColumns.jsx
@@ -13,16 +13,24 @@ import {
 } from './TableCells';
 
 function resultAttempts(result) {
-  const attempts = [result?.value1, result?.value2, result?.value3, result?.value4, result?.value5]
-    .filter(Boolean);
+  const definedAttempts = [
+    result?.value1,
+    result?.value2,
+    result?.value3,
+    result?.value4,
+    result?.value5,
+  ].filter((res) => res !== undefined);
 
-  const bestResult = _.max(attempts);
-  const worstResult = _.min(attempts);
+  const validAttempts = definedAttempts.filter((res) => res !== 0);
+  const completedAttempts = validAttempts.filter((res) => res > 0);
 
-  const bestResultIndex = attempts.indexOf(bestResult);
-  const worstResultIndex = attempts.indexOf(worstResult);
+  const worstResult = _.max(completedAttempts);
+  const bestResult = _.min(completedAttempts);
 
-  return [attempts, bestResultIndex, worstResultIndex];
+  const bestResultIndex = definedAttempts.indexOf(bestResult);
+  const worstResultIndex = definedAttempts.indexOf(worstResult);
+
+  return [definedAttempts, bestResultIndex, worstResultIndex];
 }
 
 export const resultsFiveWideColumn = {