Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding GitHub option on our website #55

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

adding GitHub option on our website #55

wants to merge 7 commits into from

Conversation

h4l0gen
Copy link
Contributor

@h4l0gen h4l0gen commented May 23, 2024 •
edited
Loading

Adding GitHub on main page and main menu.
This PR will solve Add a more explicit Github link to the website #28 issue.
fixes #28

@h4l0gen h4l0gen changed the title adding GitHub link for all repositories adding GitHub option on our website May 23, 2024
@h4l0gen
Copy link
Contributor Author

h4l0gen commented May 23, 2024

This will not only solve issue related to specification repo, It will provide clear guidance to users to join TUF GitHub directly from website. After its merging, I will attach this with my contributing page PR. Please take a look
Thank you!

@h4l0gen h4l0gen force-pushed the add_github_logo branch from f7955d1 to 7b329f4 Compare May 24, 2024 05:48
@h4l0gen h4l0gen mentioned this pull request May 25, 2024
Open
@joshuagl
Copy link
Member

joshuagl commented Jun 3, 2024

Thanks for the contribution! I'm not a fan of this being the most prominent link on the website, I think it's better suited as a child of the Community menu. WDYT?

@h4l0gen
Copy link
Contributor Author

h4l0gen commented Jun 3, 2024 •
edited
Loading

SGTM 👍, One more suggestion, IMO we should add GitHub and Slack icon in footer.html and that will redirect users to contribute->GitHub and slack channel, instead of giving GitHub option on home page. By this we can remove slack submenu and GitHub and slack is approachable from every page of website. WDYT? @joshuagl

h4l0gen added 3 commits June 3, 2024 18:14
@h4l0gen
adding GitHub for all repositories
9f8c6cf 
Signed-off-by: h4l0gen <[email protected]>

updating

Signed-off-by: h4l0gen <[email protected]>
@h4l0gen
adding brief intro of repo
8ad95a3 
Signed-off-by: h4l0gen <[email protected]>
@h4l0gen
adding github and slack
caa61c3 
Signed-off-by: h4l0gen <[email protected]>
@h4l0gen h4l0gen force-pushed the add_github_logo branch from 7b329f4 to caa61c3 Compare June 3, 2024 12:45
@h4l0gen
Copy link
Contributor Author

h4l0gen commented Jun 3, 2024

@joshuagl with these changes website looks maintained to me. Please provide your feedback. Publication and project weight orders are same, so i corrected them here

@joshuagl
Copy link
Member

joshuagl commented Jun 3, 2024

Thanks for fixing the publications and projects weightings.

I'm not convinced having chat and GitHub links in the footer is that noticeable given how busy the footer already is and how they are squashed together (at least here in Firefox 126):

Screenshot 2024-06-03 at 14 11 24

Let's at least keep the chat link in the community menu.

@h4l0gen
Copy link
Contributor Author

h4l0gen commented Jun 3, 2024 •
edited
Loading

Okay, @joshuagl what about putting GitHub option as box on home page as I did initially, or GitHub is good at footer?

IMO we should keep GitHub and slack in footer also and drop idea of putting GitHub on main page in Box. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a more explicit Github link to the website
2 participants
@h4l0gen @joshuagl