Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent calling function on undefined fileInstance #34

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

PhilWaldmann
Copy link

getFile() could potentially return an empty object. Calling e.g. updateStatus on that object will throw an error.
I observed this behavior on Firefox. E.g. the thumbnailevent-handler was invoked after the this.files was cleared. It resulted in:

TypeError: this.getFile(...).updateDataUrl is not a function
  at this(~/vue-clip/dist/vue-clip.js:992:0)
  at fn(~/vue/dist/vue.esm.js:163:0)
  at callback(~/vue-clip/dist/vue-clip.js:1836:0)
  at _this(~/vue-clip/dist/vue-clip.js:2902:0)

Firefox 54 and 52
vue-clip 1.0.0
vue 2.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant