Date aware examples #325
Open
Date aware examples #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwallwork23
force-pushed
the
date-aware-examples
branch
from
255e76d
to
fff2666
Compare
stephankramer
previously approved these changes
Feb 29, 2024
examples/north_sea/model_config.py
Outdated
| start_date = model_options.pop("start_date", default_start_date) | ||
| end_date = model_options.pop("end_date", default_end_date) | ||
| dt = 3600.0 | ||
| t_export = 3600.0 | ||
| t_end = (end_date - start_date).total_seconds() | ||
| if os.getenv("THETIS_REGRESSION_TEST") is not None: | ||
| t_end = 5 * t_export | ||
| end_date = datetime.datetime(2022, 1, 1, 0, 5, tzinfo=sim_tz) |
There was a problem hiding this comment.
That's 5 minutes past midnight, no? but the timestep is in hours?
There was a problem hiding this comment.
Good spot! Fixed in 1b07342.
|
[Merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short PR to make the Tohoku example date-aware. I also noticed that the North Sea example wasn't set up properly for testing: a shorter
t_endvalue was set but unused.