Fix checkpoint loading error in 2D Tsunami demo #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kpoints as CheckpointFile by default. Demo attempted to load files as DumbCheckpoint class, which resulted in error
jwallwork23
requested changes
Aug 30, 2022
Comment on lines
+235
to
+240
| "/home/franc/firedrake/lib/python3.10/site-packages/pyproj/crs/crs.py:130: FutureWarning: '+init=<authority>:<code>' syntax is deprecated. '<authority>:<code>' is the preferred initialization method. When making the change, be mindful of axis order changes: https://pyproj4.github.io/pyproj/stable/gotchas.html#axis-order-changes-in-proj-6\n", | ||
| " in_crs_string = _prepare_from_proj_string(in_crs_string)\n", | ||
| "/home/franc/firedrake/lib/python3.10/site-packages/pyproj/crs/crs.py:130: FutureWarning: '+init=<authority>:<code>' syntax is deprecated. '<authority>:<code>' is the preferred initialization method. When making the change, be mindful of axis order changes: https://pyproj4.github.io/pyproj/stable/gotchas.html#axis-order-changes-in-proj-6\n", | ||
| " in_crs_string = _prepare_from_proj_string(in_crs_string)\n", | ||
| "/tmp/ipykernel_11769/1221867342.py:3: DeprecationWarning: This function is deprecated. See: https://pyproj4.github.io/pyproj/stable/gotchas.html#upgrading-to-pyproj-2-from-pyproj-1\n", | ||
| " lon, lat = pyproj.transform(inproj, outproj, mesh_coordinates[:,0], mesh_coordinates[:,1])\n" |
There was a problem hiding this comment.
Please could you fix this deprecation error as described here?
Comment on lines
+465
to
468
| " dc = CheckpointFile(filename, mode=FILE_READ)\n", | ||
| " test = dc.load_mesh()\n", | ||
| " elev = dc.load_function(test, 'elev_2d')\n", | ||
| " dc.close()\n", |
There was a problem hiding this comment.
Perhaps use a variable name other than dc? Since we are no longer referring to DumbCheckpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2D Tsunami Demo throws error when attempting to display results. This is because
solver2dsaves checkpoints asCheckpointFileby default, but results were being loaded in asDumbCheckpoint. Fixed notebook to load appropriately.