Skip to content

Commit

Permalink
chore: Remove isInternal property on roots
Browse files Browse the repository at this point in the history
  • Loading branch information
thetarnav committed Jan 2, 2025
1 parent ed4215b commit fa67f61
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
6 changes: 3 additions & 3 deletions packages/debugger/src/main/roots.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ export function attachDebugger(owner = setup.solid.getOwner()): void {
let isFirstTopLevel = true
while (owner) {
if (isSolidRoot(owner)) {
// INTERNAL | disposed
if (owner.isInternal || owner.isDisposed) return
// disposed
if (owner.isDisposed) return
// already attached
if (RootMap.has(getSdtId(owner, ObjectType.Owner))) {
isFirstTopLevel = false
Expand Down Expand Up @@ -149,7 +149,7 @@ export function unobserveAllRoots(): void {
export function getTopRoot(owner: Solid.Owner): Solid.Root | null {
let root: Solid.Root | null = null
do {
if (isSolidRoot(owner) && !owner.isInternal && !owner.isDisposed) root = owner
if (isSolidRoot(owner) && !owner.isDisposed) root = owner
owner = owner.owner!
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
} while (owner)
Expand Down
1 change: 0 additions & 1 deletion packages/debugger/src/main/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ export namespace Solid {
export type Root = OwnerBase & {
attachedTo?: Owner
isDisposed?: true
isInternal?: true

context: null
fn?: never
Expand Down

0 comments on commit fa67f61

Please sign in to comment.