Skip to content

ASoC: SOF: Intel: select SND_SOC_SDW_UTILS in SND_SOC_SOF_HDA_GENERIC#5564

Merged
bardliao merged 1 commit intothesofproject:topic/sof-devfrom
bardliao:fix-undefined
Oct 28, 2025
Merged

ASoC: SOF: Intel: select SND_SOC_SDW_UTILS in SND_SOC_SOF_HDA_GENERIC#5564
bardliao merged 1 commit intothesofproject:topic/sof-devfrom
bardliao:fix-undefined

Conversation

@bardliao
Copy link
Collaborator

The "ASoC: SOF: Intel: use sof_sdw as default SDW machine driver" commit uses asoc_sdw_get_codec_info_list_count() and codec_info_list[] in the hda_sdw_machine_select() function. Select SND_SOC_SDW_UTILS to fix the function undefined issue.

Reported-by: kernel test robot lkp@intel.com
Closes: https://lore.kernel.org/oe-kbuild-all/202510220819.KrN5gjKL-lkp@intel.com/
Fixes: 5226d19 ("ASoC: SOF: Intel: use sof_sdw as default SDW machine driver")

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a build issue by adding a missing dependency for SoundWire utility functions. The commit "ASoC: SOF: Intel: use sof_sdw as default SDW machine driver" introduced usage of SoundWire utility functions without declaring the required dependency, causing undefined function errors during kernel builds.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@ujfalusi ujfalusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to move out the sdw things from hda code to their own file?

select SND_INTEL_DSP_CONFIG
select SND_SOC_SOF_HDA_LINK_BASELINE
select SND_SOC_SOF_HDA_PROBES
select SND_SOC_SDW_UTILS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

select SND_SOC_SDW_UTILS if SND_SOC_SOF_INTEL_SOUNDWIRE

The "ASoC: SOF: Intel: use sof_sdw as default SDW machine driver" commit
uses asoc_sdw_get_codec_info_list_count() and codec_info_list[] in the
hda_sdw_machine_select() function. Select SND_SOC_SDW_UTILS to fix the
function undefined issue.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202510220819.KrN5gjKL-lkp@intel.com/
Fixes: 5226d19 ("ASoC: SOF: Intel: use sof_sdw as default SDW machine driver")
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
@bardliao
Copy link
Collaborator Author

Would it make sense to move out the sdw things from hda code to their own file?

But it is more about machine driver selecting not sdw.

@ujfalusi
Copy link
Collaborator

Would it make sense to move out the sdw things from hda code to their own file?

But it is more about machine driver selecting not sdw.

sdw machine driver selection to be precise...

Copy link
Collaborator

@ujfalusi ujfalusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bardliao, I hope this will not blow up in randconfig ;)

@bardliao
Copy link
Collaborator Author

@bardliao, I hope this will not blow up in randconfig ;)

I hope we can run the randconfig test in our CI. :)

@bardliao bardliao merged commit 876ac99 into thesofproject:topic/sof-dev Oct 28, 2025
8 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants