ASoC: SOF: Intel: select SND_SOC_SDW_UTILS in SND_SOC_SOF_HDA_GENERIC#5564
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a build issue by adding a missing dependency for SoundWire utility functions. The commit "ASoC: SOF: Intel: use sof_sdw as default SDW machine driver" introduced usage of SoundWire utility functions without declaring the required dependency, causing undefined function errors during kernel builds.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ujfalusi
left a comment
There was a problem hiding this comment.
Would it make sense to move out the sdw things from hda code to their own file?
sound/soc/sof/intel/Kconfig
Outdated
| select SND_INTEL_DSP_CONFIG | ||
| select SND_SOC_SOF_HDA_LINK_BASELINE | ||
| select SND_SOC_SOF_HDA_PROBES | ||
| select SND_SOC_SDW_UTILS |
There was a problem hiding this comment.
select SND_SOC_SDW_UTILS if SND_SOC_SOF_INTEL_SOUNDWIRE
The "ASoC: SOF: Intel: use sof_sdw as default SDW machine driver" commit uses asoc_sdw_get_codec_info_list_count() and codec_info_list[] in the hda_sdw_machine_select() function. Select SND_SOC_SDW_UTILS to fix the function undefined issue. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202510220819.KrN5gjKL-lkp@intel.com/ Fixes: 5226d19 ("ASoC: SOF: Intel: use sof_sdw as default SDW machine driver") Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
c7de1a7 to
763685d
Compare
But it is more about machine driver selecting not sdw. |
sdw machine driver selection to be precise... |
I hope we can run the randconfig test in our CI. :) |
The "ASoC: SOF: Intel: use sof_sdw as default SDW machine driver" commit uses asoc_sdw_get_codec_info_list_count() and codec_info_list[] in the hda_sdw_machine_select() function. Select SND_SOC_SDW_UTILS to fix the function undefined issue.
Reported-by: kernel test robot lkp@intel.com
Closes: https://lore.kernel.org/oe-kbuild-all/202510220819.KrN5gjKL-lkp@intel.com/
Fixes: 5226d19 ("ASoC: SOF: Intel: use sof_sdw as default SDW machine driver")