Skip to content

ASoC: SOF: ipc4-topology: Fixes for exotic format handling for DMIC and SSP #5559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ujfalusi merged 2 commits into from
Oct 27, 2025
Merged

ASoC: SOF: ipc4-topology: Fixes for exotic format handling for DMIC and SSP #5559

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a26da9
ASoC: SOF: ipc4-topology: Prefer 32-bit DMIC blobs for 8-bit formats …
ujfalusi Oct 17, 2025
f18da5a
ASoC: SOF: ipc4-topology: Convert FLOAT to S32 during blob selection
ujfalusi Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions sound/soc/sof/ipc4-topology.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1758,11 +1758,9 @@ snd_sof_get_nhlt_endpoint_data(struct snd_sof_dev *sdev, struct snd_sof_dai *dai
channel_count = params_channels(params);
sample_rate = params_rate(params);
bit_depth = params_width(params);
/*
* Look for 32-bit blob first instead of 16-bit if copier
* supports multiple formats
*/
if (bit_depth == 16 && !single_bitdepth) {

/* Prefer 32-bit blob if copier supports multiple formats */
if (bit_depth <= 16 && !single_bitdepth) {
dev_dbg(sdev->dev, "Looking for 32-bit blob first for DMIC\n");
format_change = true;
bit_depth = 32;
Expand Down Expand Up @@ -1805,10 +1803,18 @@ snd_sof_get_nhlt_endpoint_data(struct snd_sof_dev *sdev, struct snd_sof_dai *dai
if (format_change) {
/*
* The 32-bit blob was not found in NHLT table, try to
* look for one based on the params
* look for 16-bit for DMIC or based on the params for
* SSP
*/
bit_depth = params_width(params);
format_change = false;
if (linktype == SOF_DAI_INTEL_DMIC) {
bit_depth = 16;
if (params_width(params) == 16)
format_change = false;
} else {
bit_depth = params_width(params);
format_change = false;
}

get_new_blob = true;
} else if (linktype == SOF_DAI_INTEL_DMIC && !single_bitdepth) {
/*
Expand Down Expand Up @@ -1843,7 +1849,7 @@ snd_sof_get_nhlt_endpoint_data(struct snd_sof_dev *sdev, struct snd_sof_dai *dai
*len = cfg->size >> 2;
*dst = (u32 *)cfg->caps;

if (format_change) {
if (format_change || params_format(params) == SNDRV_PCM_FORMAT_FLOAT_LE) {
/*
* Update the params to reflect that different blob was loaded
* instead of the requested bit depth (16 -> 32 or 32 -> 16).
Expand Down
Loading