ASoC: SOF: ipc3-topology: Fix multi-core and static pieplines tear down#5545
Merged
ujfalusi merged 1 commit intothesofproject:topic/sof-devfrom Oct 1, 2025
Merged
Conversation
ranj063
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart and
ujfalusi
as code owners
kv2019i
reviewed
Sep 30, 2025
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Code looks good, some minor nits in the commit message.
In the case of static pipelines, freeing the widgets in the pipelines that were not suspended after freeing the scheduler widgets results in errors because the secondary cores are powered off when the scheduler widgets are freed. Fix this by tearing down the leftover pipelines before powering off the secondary cores. Fixes: d7332c4 ("ASoC: SOF: ipc3-topology: Fix pipeline tear down logic") Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
ranj063
force-pushed
the
sof-dev-092925
branch
from
3abf6fa to
78b451a
Compare
ujfalusi
approved these changes
Sep 30, 2025
kv2019i
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case of static pipelines, freeing the widgets in the pipelines that were left over after freeing the scheduler widgets results in errors because the secondary cores are powered off when the scheduler widgets are freed. Fix this by tearing down the left over pipelines before powering off the secondary cores.
Fixes: d7332c4 ("ASoC: SOF: ipc3-topology: Fix pipeline tear down logic")